Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2585173002:
Files App: Remove unused metrics FileBrowser.Load.*. (Closed)
DescriptionFiles App: Obsolete unused metrics FileBrowser.Load.*.
Following metrics are no longer used hence obsoleted:
FileBrowser.Load.Construct
FileBrowser.Load.DOM
FileBrowser.Load.FileSystem
FileBrowser.Load.Parse
FileBrowser.Load.Roots
BUG=675507
TEST=None
Committed: https://crrev.com/a709ed233dd45d6f3b1df8f28e1e5608a796a05b
Cr-Commit-Position: refs/heads/master@{#439687}
Patch Set 1 #Patch Set 2 : Use obsolete tag instead of removing. #Patch Set 3 : Rebased. #Messages
Total messages: 25 (14 generated)
Description was changed from ========== Files App: Remove unused metrics FileBrowser.Load.*. Removed the following metrics: FileBrowser.Load.DOM FileBrowser.Load.FileSystem FileBrowser.Load.Parse FileBrowser.Load.Roots BUG=675507 TEST=None ========== to ========== Files App: Remove unused metrics FileBrowser.Load.*. Removed the following metrics: FileBrowser.Load.Construct FileBrowser.Load.DOM FileBrowser.Load.FileSystem FileBrowser.Load.Parse FileBrowser.Load.Roots BUG=675507 TEST=None ==========
oka@chromium.org changed reviewers: + fukino@chromium.org, jwd@chromium.org
PTAL.
On 2016/12/19 05:50:09, oka wrote: > PTAL. I'm not sure if we can delete entries. Could you check https://codesearch.chromium.org/chromium/src/tools/metrics/histograms/README.md ?
Description was changed from ========== Files App: Remove unused metrics FileBrowser.Load.*. Removed the following metrics: FileBrowser.Load.Construct FileBrowser.Load.DOM FileBrowser.Load.FileSystem FileBrowser.Load.Parse FileBrowser.Load.Roots BUG=675507 TEST=None ========== to ========== Files App: Obsolete unused metrics FileBrowser.Load.*. Following metrics are no longer used hence obsoleted: FileBrowser.Load.Construct FileBrowser.Load.DOM FileBrowser.Load.FileSystem FileBrowser.Load.Parse FileBrowser.Load.Roots BUG=675507 TEST=None ==========
On 2016/12/19 05:58:40, fukino wrote: > On 2016/12/19 05:50:09, oka wrote: > > PTAL. > > I'm not sure if we can delete entries. > Could you check > https://codesearch.chromium.org/chromium/src/tools/metrics/histograms/README.md > ? Followed https://chromium.googlesource.com/chromium/src/+/lkgr/tools/metrics/histogram..., which reads "Do not delete histograms from histograms.xml. Instead, mark unused histograms as obsolete, annotating them with the associated date or milestone in the obsolete tag entry."
lgtm
The CQ bit was checked by oka@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2585483003 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by oka@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2585483003 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by oka@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by oka@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jwd@chromium.org Link to the patchset: https://codereview.chromium.org/2585173002/#ps40001 (title: "Rebased.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482199461497710,
"parent_rev": "5e30fa66f3bb0bf5c7d4c5c995d54e86a81e8f04", "commit_rev":
"7debb45c19887c0a9d69e632b3d8fd519afd1a84"}
Message was sent while issue was closed.
Description was changed from ========== Files App: Obsolete unused metrics FileBrowser.Load.*. Following metrics are no longer used hence obsoleted: FileBrowser.Load.Construct FileBrowser.Load.DOM FileBrowser.Load.FileSystem FileBrowser.Load.Parse FileBrowser.Load.Roots BUG=675507 TEST=None ========== to ========== Files App: Obsolete unused metrics FileBrowser.Load.*. Following metrics are no longer used hence obsoleted: FileBrowser.Load.Construct FileBrowser.Load.DOM FileBrowser.Load.FileSystem FileBrowser.Load.Parse FileBrowser.Load.Roots BUG=675507 TEST=None Review-Url: https://codereview.chromium.org/2585173002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Files App: Obsolete unused metrics FileBrowser.Load.*. Following metrics are no longer used hence obsoleted: FileBrowser.Load.Construct FileBrowser.Load.DOM FileBrowser.Load.FileSystem FileBrowser.Load.Parse FileBrowser.Load.Roots BUG=675507 TEST=None Review-Url: https://codereview.chromium.org/2585173002 ========== to ========== Files App: Obsolete unused metrics FileBrowser.Load.*. Following metrics are no longer used hence obsoleted: FileBrowser.Load.Construct FileBrowser.Load.DOM FileBrowser.Load.FileSystem FileBrowser.Load.Parse FileBrowser.Load.Roots BUG=675507 TEST=None Committed: https://crrev.com/a709ed233dd45d6f3b1df8f28e1e5608a796a05b Cr-Commit-Position: refs/heads/master@{#439687} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a709ed233dd45d6f3b1df8f28e1e5608a796a05b Cr-Commit-Position: refs/heads/master@{#439687} |
