Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2584763002: Mojo C++ bindings: remove support for generating code with mojo::Array/String/Map/WTFArray/WTFMap. (Closed)

Created:
4 years ago by yzshen1
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: remove support for generating code with mojo::Array/String/Map/WTFArray/WTFMap. BUG=624136 Committed: https://crrev.com/db95936119dc548c8c511f74a159ae01df788ff1 Cr-Commit-Position: refs/heads/master@{#438992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -97 lines) Patch
M PRESUBMIT.py View 2 chunks +0 lines, -27 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl View 1 chunk +2 lines, -14 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 7 chunks +9 lines, -28 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 2 chunks +0 lines, -14 lines 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.py View 2 chunks +0 lines, -5 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/generator.py View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
yzshen1
Hi, Dirk. Would you please take a look at the changes to PRESUMBIT? The old ...
4 years ago (2016-12-16 00:07:10 UTC) #4
Dirk Pranke
PRESUBMIT change lgtm!
4 years ago (2016-12-16 00:33:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584763002/1
4 years ago (2016-12-16 00:34:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 02:41:44 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-16 02:44:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db95936119dc548c8c511f74a159ae01df788ff1
Cr-Commit-Position: refs/heads/master@{#438992}

Powered by Google App Engine
This is Rietveld 408576698