Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1747)

Unified Diff: mojo/public/tools/bindings/mojom.gni

Issue 2584763002: Mojo C++ bindings: remove support for generating code with mojo::Array/String/Map/WTFArray/WTFMap. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/mojom.gni
diff --git a/mojo/public/tools/bindings/mojom.gni b/mojo/public/tools/bindings/mojom.gni
index d9d999a2c6aae0e61f9fcf361655b9ba6ac3e733..a30e10ce4380798969f5c788fd127525413974bd 100644
--- a/mojo/public/tools/bindings/mojom.gni
+++ b/mojo/public/tools/bindings/mojom.gni
@@ -87,15 +87,6 @@ foreach(configuration, _bindings_configurations) {
#
# visibility (optional)
#
-# use_new_wrapper_types (optional)
-# If set to true, mojom array/map/string will be mapped to STL (for
-# chromium variant) or WTF (for blink) types. Otherwise, they will be
-# mapped to mojo::Array/Map/String/etc.
-# Default value is true.
-# TODO(yzshen):
-# - convert all users to use the new mode;
-# - remove support for the old mode.
-#
# use_once_callback (optional)
# If set to true, generated classes will use base::OnceCallback instead of
# base::RepeatingCallback.
@@ -363,11 +354,6 @@ template("mojom") {
}
}
- if (!defined(invoker.use_new_wrapper_types) ||
- invoker.use_new_wrapper_types) {
- args += [ "--use_new_wrapper_types" ]
- }
-
if (defined(invoker.use_once_callback) && invoker.use_once_callback) {
args += [ "--use_once_callback" ]
}
« no previous file with comments | « mojo/public/tools/bindings/generators/mojom_cpp_generator.py ('k') | mojo/public/tools/bindings/mojom_bindings_generator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698