Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: PRESUBMIT.py

Issue 2584763002: Mojo C++ bindings: remove support for generating code with mojo::Array/String/Map/WTFArray/WTFMap. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 4256e2a57fdaa80abd0a8067cf04cb08ef4e31f1..395e695e4a54465c5c7de333eae4b277bee53417 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -1551,32 +1551,6 @@ def _CheckIpcOwners(input_api, output_api):
return results
-def _CheckMojoUsesNewWrapperTypes(input_api, output_api):
- """Checks to make sure that all newly added mojom targets map array/map/string
- to STL (for chromium) or WTF (for blink) types.
- TODO(yzshen): remove this check once crbug.com/624136 is completed.
- """
- files = []
- pattern = input_api.re.compile(r'use_new_wrapper_types.*false',
- input_api.re.MULTILINE)
-
- for f in input_api.AffectedFiles():
- if not f.LocalPath().endswith(('.gyp', '.gypi', 'gn', 'gni')):
- continue
-
- for _, line in f.ChangedContents():
- if pattern.search(line):
- files.append(f)
- break
-
- if len(files):
- return [output_api.PresubmitError(
- 'Do not introduce new mojom targets with use_new_wrapper_types set to '
- 'false. The mode is deprecated and will be removed soon.',
- files)]
- return []
-
-
def _CheckUselessForwardDeclarations(input_api, output_api):
"""Checks that added or removed lines in non third party affected
header files do not lead to new useless class or struct forward
@@ -2093,7 +2067,6 @@ def _CommonChecks(input_api, output_api):
results.extend(_CheckPydepsNeedsUpdating(input_api, output_api))
results.extend(_CheckJavaStyle(input_api, output_api))
results.extend(_CheckIpcOwners(input_api, output_api))
- results.extend(_CheckMojoUsesNewWrapperTypes(input_api, output_api))
results.extend(_CheckUselessForwardDeclarations(input_api, output_api))
results.extend(_CheckForRiskyJsFeatures(input_api, output_api))
« no previous file with comments | « no previous file | mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698