Media Session API: make MediaMetadata mutable.

Media Session API: make MediaMetadata mutable.

Spec discussion: https://github.com/WICG/mediasession/issues/116

BUG=674710
R=zqzhang@chromium.org

Committed: https://crrev.com/5c2e35fce0858601ae0f45a12b43f4733c384346
Cr-Commit-Position: refs/heads/master@{#439207}

[mlamouri (slow - plz ping), 2016-12-15 21:56:00]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[mlamouri (slow - plz ping), 2016-12-15 21:56:35]

PTAL

[commit-bot: I haz the power, 2016-12-15 21:56:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 23:30:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 23:30:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Zhiqiang Zhang (Slow), 2016-12-16 16:01:47]

lgtm

https://codereview.chromium.org/2584703002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/mediasession/MediaMetadata.h (right):

https://codereview.chromium.org/2584703002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/mediasession/MediaMetadata.h:60: void
notifySessionFired(TimerBase*);
nit: s/notifySessionFired/notifySessionTimerFired

[Zhiqiang Zhang (Slow), 2016-12-16 16:02:27]

BTW, the web-exposed layout tests seems to need fix :)

[mlamouri (slow - plz ping), 2016-12-16 18:43:40]

https://codereview.chromium.org/2584703002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/mediasession/MediaMetadata.h (right):

https://codereview.chromium.org/2584703002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/mediasession/MediaMetadata.h:60: void
notifySessionFired(TimerBase*);
On 2016/12/16 at 16:01:47, Zhiqiang Zhang wrote:
> nit: s/notifySessionFired/notifySessionTimerFired

Done.

[mlamouri (slow - plz ping), 2016-12-16 18:43:48]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-12-16 18:43:48]

The patchset sent to the CQ was uploaded after l-g-t-m from zqzhang@chromium.org
Link to the patchset: https://codereview.chromium.org/2584703002/#ps20001
(title: "review comments and tests")

[commit-bot: I haz the power, 2016-12-16 18:44:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 22:05:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481913828454300,
"parent_rev": "75c2ecea913080f8c040ca8fe3b6978b456a47ab", "commit_rev":
"60b0491a78d96c8ac5fa77bda8fd39792727b12d"}

[commit-bot: I haz the power, 2016-12-16 22:06:14]

Description was changed from

==========
Media Session API: make MediaMetadata mutable.

Spec discussion: https://github.com/WICG/mediasession/issues/116

BUG=674710
R=zqzhang@chromium.org
==========

to

==========
Media Session API: make MediaMetadata mutable.

Spec discussion: https://github.com/WICG/mediasession/issues/116

BUG=674710
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2584703002
==========

[commit-bot: I haz the power, 2016-12-16 22:06:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-16 22:08:32]

Description was changed from

==========
Media Session API: make MediaMetadata mutable.

Spec discussion: https://github.com/WICG/mediasession/issues/116

BUG=674710
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2584703002
==========

to

==========
Media Session API: make MediaMetadata mutable.

Spec discussion: https://github.com/WICG/mediasession/issues/116

BUG=674710
R=zqzhang@chromium.org

Committed: https://crrev.com/5c2e35fce0858601ae0f45a12b43f4733c384346
Cr-Commit-Position: refs/heads/master@{#439207}
==========

[commit-bot: I haz the power, 2016-12-16 22:08:33]

Patchset 2 (id:??) landed as
https://crrev.com/5c2e35fce0858601ae0f45a12b43f4733c384346
Cr-Commit-Position: refs/heads/master@{#439207}

[François Beaufort, 2016-12-23 14:17:33]

On 2016/12/16 22:08:33, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/5c2e35fce0858601ae0f45a12b43f4733c384346
> Cr-Commit-Position: refs/heads/master@{#439207}

Thank you so much! ❤