Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html

Issue 2584703002: Media Session API: make MediaMetadata mutable. (Closed)
Patch Set: review comments and tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html
diff --git a/third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html b/third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html
index 6297cac1a65c06017b74efdc9c26b9ed11ab7507..bfa59ba54a196f2ae4e89cfe5a9a42d095e4d9d4 100644
--- a/third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html
+++ b/third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html
@@ -21,7 +21,7 @@
metadata = new MediaMetadata(42);
} catch (e) {
exception = true;
- }
+ }
assert_true(exception);
}, 'Test that MediaMetadata is constructed using a dictionary');
@@ -58,4 +58,27 @@
assert_equals(metadata.randomValueThatWillNotBeAdded, undefined);
}, 'Test that passing unknown values to the dictionary is a no-op');
+ test(function() {
+ var metadata = new MediaMetadata({
+ title: 'foo', album: 'bar', artist: 'plop',
+ artwork: [ { src: 'src1', sizes: 'sizes1', type: 'type1'},
+ { src: 'src2', sizes: 'sizes2', type: 'type2'} ] });
+
+ metadata.title = 'something else';
+ assert_equals(metadata.title, 'something else');
+
+ metadata.album = 'other value';
+ assert_equals(metadata.album, 'other value');
+
+ metadata.artist = 'someone else';
+ assert_equals(metadata.artist, 'someone else');
+
+ var image = new MediaImage({ src: 'http://example.com/', sizes: '40x40', type: 'image/png' });
+ metadata.artwork = [ image ];
+ assert_equals(metadata.artwork.length, 1);
+ assert_equals(metadata.artwork[0].src, 'http://example.com/');
+ assert_equals(metadata.artwork[0].sizes, '40x40');
+ assert_equals(metadata.artwork[0].type, 'image/png');
+ }, "Test that MediaMetadata is read/write");
+
</script>

Powered by Google App Engine
This is Rietveld 408576698