Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/modules/mediasession/MediaSession.cpp

Issue 2584703002: Media Session API: make MediaMetadata mutable. (Closed)
Patch Set: review comments and tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/mediasession/MediaSession.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/mediasession/MediaSession.cpp
diff --git a/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp b/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp
index b723323b95aebfa0441d76589fd913e89b82099c..e4579cbef0a803d6f2506b0999b0c8820e6110cc 100644
--- a/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp
+++ b/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp
@@ -80,16 +80,29 @@ void MediaSession::dispose() {
}
void MediaSession::setMetadata(MediaMetadata* metadata) {
- if (mojom::blink::MediaSessionService* service = getService()) {
- service->SetMetadata(MediaMetadataSanitizer::sanitizeAndConvertToMojo(
- metadata, getExecutionContext()));
- }
+ if (metadata)
+ metadata->setSession(this);
+
+ if (m_metadata)
+ m_metadata->setSession(nullptr);
+
+ m_metadata = metadata;
+ onMetadataChanged();
}
MediaMetadata* MediaSession::metadata() const {
return m_metadata;
}
+void MediaSession::onMetadataChanged() {
+ mojom::blink::MediaSessionService* service = getService();
+ if (!service)
+ return;
+
+ service->SetMetadata(MediaMetadataSanitizer::sanitizeAndConvertToMojo(
+ m_metadata, getExecutionContext()));
+}
+
const WTF::AtomicString& MediaSession::interfaceName() const {
return EventTargetNames::MediaSession;
}
« no previous file with comments | « third_party/WebKit/Source/modules/mediasession/MediaSession.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698