Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2584683002: Return unique_ptr from CFX_BinaryBuf::DetachBuffer() (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Return unique_ptr from CFX_BinaryBuf::DetachBuffer() In turn, make CPDF_Stream() take an unique_ptr. Review-Url: https://codereview.chromium.org/2584683002 Committed: https://pdfium.googlesource.com/pdfium/+/47fb8c06acd0ff9ea50c8c2d7f67510ea5c28577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -40 lines) Patch
M core/fpdfapi/page/cpdf_image.cpp View 4 chunks +9 lines, -8 lines 0 comments Download
M core/fpdfapi/page/cpdf_streamparser.cpp View 2 chunks +10 lines, -8 lines 0 comments Download
M core/fpdfapi/parser/cpdf_object_unittest.cpp View 3 chunks +10 lines, -9 lines 0 comments Download
M core/fpdfapi/parser/cpdf_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_stream.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_syntax_parser.cpp View 1 chunk +7 lines, -8 lines 0 comments Download
M core/fxcrt/fx_basic.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/fx_basic_buffer.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Dan, ready for review.
4 years ago (2016-12-15 21:22:23 UTC) #4
dsinclair
lgtm
4 years ago (2016-12-15 21:48:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584683002/1
4 years ago (2016-12-15 21:48:20 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-15 21:51:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/47fb8c06acd0ff9ea50c8c2d7f67510ea5c2...

Powered by Google App Engine
This is Rietveld 408576698