core/fxcrt/fx_basic.h - Issue 2584683002: Return unique_ptr from CFX_BinaryBuf::DetachBuffer()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/fx_basic.h

Issue 2584683002: Return unique_ptr from CFX_BinaryBuf::DetachBuffer() (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/fx_basic.h

diff --git a/core/fxcrt/fx_basic.h b/core/fxcrt/fx_basic.h

index e974e3061cfd2dc7d4457cf6cf8737d2034763d4..7096e6f8dffac376e93c2ac7193035b0e74e14d6 100644

--- a/core/fxcrt/fx_basic.h

+++ b/core/fxcrt/fx_basic.h

@@ -41,7 +41,7 @@ class CFX_BinaryBuf {

void Delete(int start_index, int count);

// Releases ownership of |m_pBuffer| and returns it.

- uint8_t* DetachBuffer();

+ std::unique_ptr<uint8_t, FxFreeDeleter> DetachBuffer();

protected:

void ExpandBuf(FX_STRSIZE size);

« no previous file with comments | « core/fpdfapi/parser/cpdf_syntax_parser.cpp ('k') | core/fxcrt/fx_basic_buffer.cpp » ('j') | no next file with comments »