core/fpdfapi/parser/cpdf_stream.h - Issue 2584683002: Return unique_ptr from CFX_BinaryBuf::DetachBuffer()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/cpdf_stream.h

Issue 2584683002: Return unique_ptr from CFX_BinaryBuf::DetachBuffer() (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/cpdf_stream.h

diff --git a/core/fpdfapi/parser/cpdf_stream.h b/core/fpdfapi/parser/cpdf_stream.h

index cd4113b22b6cd31697116d8b9f69c43c66a7fc93..902cd75365ce914cb67664b60290663c4e577c55 100644

--- a/core/fpdfapi/parser/cpdf_stream.h

+++ b/core/fpdfapi/parser/cpdf_stream.h

@@ -19,7 +19,7 @@ class CPDF_Stream : public CPDF_Object {

CPDF_Stream();

// Takes ownership of |pData|.

- CPDF_Stream(uint8_t* pData,

+ CPDF_Stream(std::unique_ptr<uint8_t, FxFreeDeleter> pData,

uint32_t size,

std::unique_ptr<CPDF_Dictionary> pDict);

« no previous file with comments | « core/fpdfapi/parser/cpdf_object_unittest.cpp ('k') | core/fpdfapi/parser/cpdf_stream.cpp » ('j') | no next file with comments »