Fix ntp-tiles-internals crash in incognito mode

Fix ntp-tiles-internals crash in incognito mode

NTP Tiles aren't supported in Incognito mode, so disable the handlers in
that case.

BUG=674441
Review-Url: https://codereview.chromium.org/2584483002
Cr-Commit-Position: refs/heads/master@{#444050}
Committed: https://chromium.googlesource.com/chromium/src/+/b20f0039e91883b8f001390a2f21616b4ec5752d

[sfiera, 2016-12-15 11:17:28]

sfiera@chromium.org changed reviewers:
+ treib@chromium.org

[sfiera, 2016-12-15 11:17:28]

It looks pretty broken in incognito after this, but it doesn't crash.

[Marc Treib, 2016-12-15 11:21:54]

On 2016/12/15 11:17:28, sfiera wrote:
> It looks pretty broken in incognito after this, but it doesn't crash.

See IsURLAllowedInIncognito in chrome/browser/ui/browser_navigator.cc - that
seems to be how other internals pages handle this.

[sfiera, 2016-12-19 10:34:34]

On 2016/12/15 11:21:54, Marc Treib (OOO until Jan 12) wrote:
> On 2016/12/15 11:17:28, sfiera wrote:
> > It looks pretty broken in incognito after this, but it doesn't crash.
> 
> See IsURLAllowedInIncognito in chrome/browser/ui/browser_navigator.cc - that
> seems to be how other internals pages handle this.

Only used on desktop? browser_navigator.cc is in the !android_java_ui block of
ui/BUILD.gn.

[Marc Treib, 2016-12-19 11:55:22]

On 2016/12/19 10:34:34, sfiera wrote:
> On 2016/12/15 11:21:54, Marc Treib (OOO until Jan 12) wrote:
> > On 2016/12/15 11:17:28, sfiera wrote:
> > > It looks pretty broken in incognito after this, but it doesn't crash.
> > 
> > See IsURLAllowedInIncognito in chrome/browser/ui/browser_navigator.cc - that
> > seems to be how other internals pages handle this.
> 
> Only used on desktop? browser_navigator.cc is in the !android_java_ui block of
> ui/BUILD.gn.

Huh, today I learned. Alright, LGTM then!

[sfiera, 2016-12-19 11:58:18]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 11:58:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2016-12-19 12:04:03]

On 2016/12/19 11:55:22, Marc Treib (OOO until Jan 12) wrote:
> On 2016/12/19 10:34:34, sfiera wrote:
> > On 2016/12/15 11:21:54, Marc Treib (OOO until Jan 12) wrote:
> > > On 2016/12/15 11:17:28, sfiera wrote:
> > > > It looks pretty broken in incognito after this, but it doesn't crash.
> > > 
> > > See IsURLAllowedInIncognito in chrome/browser/ui/browser_navigator.cc -
that
> > > seems to be how other internals pages handle this.
> > 
> > Only used on desktop? browser_navigator.cc is in the !android_java_ui block
of
> > ui/BUILD.gn.
> 
> Huh, today I learned. Alright, LGTM then!

Hm, I think I would rather pull IsURLAllowedInIncognito() out of there and use
it in the URL loading code path for Android as well... My guess is there are a
bunch of other WebUI pages that are also broken in incognito on Android.

[sfiera, 2016-12-19 12:13:14]

On 2016/12/19 12:04:03, Bernhard Bauer wrote:
> On 2016/12/19 11:55:22, Marc Treib (OOO until Jan 12) wrote:
> > On 2016/12/19 10:34:34, sfiera wrote:
> > > On 2016/12/15 11:21:54, Marc Treib (OOO until Jan 12) wrote:
> > > > On 2016/12/15 11:17:28, sfiera wrote:
> > > > > It looks pretty broken in incognito after this, but it doesn't crash.
> > > > 
> > > > See IsURLAllowedInIncognito in chrome/browser/ui/browser_navigator.cc -
> that
> > > > seems to be how other internals pages handle this.
> > > 
> > > Only used on desktop? browser_navigator.cc is in the !android_java_ui
block
> of
> > > ui/BUILD.gn.
> > 
> > Huh, today I learned. Alright, LGTM then!
> 
> Hm, I think I would rather pull IsURLAllowedInIncognito() out of there and use
> it in the URL loading code path for Android as well... My guess is there are a
> bunch of other WebUI pages that are also broken in incognito on Android.

At a minimum, signin-internals is. snippets-internals does something different?
I'll check that.

[sfiera, 2016-12-19 12:15:24]

On 2016/12/19 12:13:14, sfiera wrote:
> On 2016/12/19 12:04:03, Bernhard Bauer wrote:
> > On 2016/12/19 11:55:22, Marc Treib (OOO until Jan 12) wrote:
> > > On 2016/12/19 10:34:34, sfiera wrote:
> > > > On 2016/12/15 11:21:54, Marc Treib (OOO until Jan 12) wrote:
> > > > > On 2016/12/15 11:17:28, sfiera wrote:
> > > > > > It looks pretty broken in incognito after this, but it doesn't
crash.
> > > > > 
> > > > > See IsURLAllowedInIncognito in chrome/browser/ui/browser_navigator.cc
-
> > that
> > > > > seems to be how other internals pages handle this.
> > > > 
> > > > Only used on desktop? browser_navigator.cc is in the !android_java_ui
> block
> > of
> > > > ui/BUILD.gn.
> > > 
> > > Huh, today I learned. Alright, LGTM then!
> > 
> > Hm, I think I would rather pull IsURLAllowedInIncognito() out of there and
use
> > it in the URL loading code path for Android as well... My guess is there are
a
> > bunch of other WebUI pages that are also broken in incognito on Android.
> 
> At a minimum, signin-internals is. snippets-internals does something
different?
> I'll check that.

Ah, it simply doesn't instantiate the WebUI:
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chrome_web_ui_co...

That sounds like an OK fix too, though it's the only WebUI that does that.

[commit-bot: I haz the power, 2016-12-19 12:43:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 12:43:07]

Dry run: This issue passed the CQ dry run.

[sfiera, 2017-01-17 12:47:04]

I haven't spent any more time investigating alternate fixes, and the crash is
marked as a stable blocker, so I'll submit this now.

[sfiera, 2017-01-17 12:47:07]

The CQ bit was checked by sfiera@chromium.org

[sfiera, 2017-01-17 12:47:08]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2584483002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-17 12:47:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 12:53:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 12:53:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sfiera, 2017-01-17 12:56:35]

sfiera@chromium.org changed reviewers:
+ bauerb@chromium.org, marq@chromium.org

[sfiera, 2017-01-17 12:56:36]

bauerb: for chrome/…
marq: for ios/…

Thanks.

[Bernhard Bauer, 2017-01-17 14:09:21]

I'm still not super happy about silently breaking the page in incognito, but I
guess it's better than crashing, so LGTM.

[marq (ping after 24h), 2017-01-17 14:28:32]

ios/ LGTM

[sfiera, 2017-01-17 14:47:51]

The CQ bit was checked by sfiera@chromium.org

[commit-bot: I haz the power, 2017-01-17 14:48:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 14:51:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484664471517160,
"parent_rev": "fa5c0f2b9380b8a93c72b5ccde08b82203fbc5b0", "commit_rev":
"b20f0039e91883b8f001390a2f21616b4ec5752d"}

[commit-bot: I haz the power, 2017-01-17 14:52:01]

Description was changed from

==========
Fix ntp-tiles-internals crash in incognito mode

NTP Tiles aren't supported in Incognito mode, so disable the handlers in
that case.

BUG=674441
==========

to

==========
Fix ntp-tiles-internals crash in incognito mode

NTP Tiles aren't supported in Incognito mode, so disable the handlers in
that case.

BUG=674441

Review-Url: https://codereview.chromium.org/2584483002
Cr-Commit-Position: refs/heads/master@{#444050}
Committed:
https://chromium.googlesource.com/chromium/src/+/b20f0039e91883b8f001390a2f21...
==========

[commit-bot: I haz the power, 2017-01-17 14:52:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b20f0039e91883b8f001390a2f21...