components/ntp_tiles/webui/ntp_tiles_internals_message_handler_client.h - Issue 2584483002: Fix ntp-tiles-internals crash in incognito mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_tiles/webui/ntp_tiles_internals_message_handler_client.h

Issue 2584483002: Fix ntp-tiles-internals crash in incognito mode (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc ('k') | ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_tiles/webui/ntp_tiles_internals_message_handler_client.h

diff --git a/components/ntp_tiles/webui/ntp_tiles_internals_message_handler_client.h b/components/ntp_tiles/webui/ntp_tiles_internals_message_handler_client.h

index 4a917008cbf2be1c1ac18e0923ac5a30bd961fcf..d26972d5fc6e725d9cd11c4f8561cea878ca9c45 100644

--- a/components/ntp_tiles/webui/ntp_tiles_internals_message_handler_client.h

+++ b/components/ntp_tiles/webui/ntp_tiles_internals_message_handler_client.h

@@ -31,6 +31,9 @@ class NTPTilesInternalsMessageHandlerClient {

// Returns the PrefService for the embedder and containing WebUI page.

virtual PrefService* GetPrefs() = 0;

+ // False if in a browser mode (e.g. incognito) where tiles aren't supported.

+ virtual bool SupportsNTPTiles() = 0;

// Returns true if the given source is enabled (even if, in practice, none of

// the tiles would come from it).

virtual bool DoesSourceExist(NTPTileSource source) = 0;