Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc

Issue 2584483002: Fix ntp-tiles-internals crash in incognito mode (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc
diff --git a/components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc b/components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc
index 4dce944c2442d3d0334c869d55c90f57fda900dc..9f876ee7efbebbdabcf9f075dff2bff721680217 100644
--- a/components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc
+++ b/components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc
@@ -44,6 +44,9 @@ void NTPTilesInternalsMessageHandler::RegisterMessages(
void NTPTilesInternalsMessageHandler::HandleRegisterForEvents(
const base::ListValue* args) {
+ if (!client_->SupportsNTPTiles()) {
+ return;
+ }
DCHECK(args->empty());
SendSourceInfo();
@@ -54,6 +57,9 @@ void NTPTilesInternalsMessageHandler::HandleRegisterForEvents(
void NTPTilesInternalsMessageHandler::HandleUpdate(
const base::ListValue* args) {
+ if (!client_->SupportsNTPTiles()) {
+ return;
+ }
const base::DictionaryValue* dict = nullptr;
DCHECK_EQ(1u, args->GetSize());
args->GetDictionary(0, &dict);

Powered by Google App Engine
This is Rietveld 408576698