Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2584253002: Specify TaskType of posted Task explicitly in networking classes (5) (Closed)

Created:
4 years ago by tzik
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify TaskType of posted Task explicitly in networking classes This CL assigns TaskType to ContentSecurityPolicy::reportViolation and NetworkStateNotifier::notifyObservers. For CSP, the spec doesn't explicitly specify the task source. However, since it's a fetch request, TaskType::Networking should be the best fit. http://wicg.github.io/reporting/#try-delivery For NetworkStateNotifier, the spec specifies it should be TaskType::Networking. https://wicg.github.io/netinfo/#dependencies-and-definitions BUG=624696 Committed: https://crrev.com/c7d47a47d6bd59baa0197569991deb7958d8657e Cr-Commit-Position: refs/heads/master@{#439385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
tzik
PTAL
4 years ago (2016-12-18 14:40:35 UTC) #5
haraken
LGTM
4 years ago (2016-12-18 14:53:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584253002/1
4 years ago (2016-12-18 22:52:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-18 22:56:34 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-18 22:59:34 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7d47a47d6bd59baa0197569991deb7958d8657e
Cr-Commit-Position: refs/heads/master@{#439385}

Powered by Google App Engine
This is Rietveld 408576698