Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2580243002: Specify TaskType of posted Task explicitly in forms (6) (Closed)

Created:
4 years ago by tzik
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify TaskType of posted Task explicitly in forms These tasks should be posted as TaskType::UserInteraction as specified on the spec. https://html.spec.whatwg.org/multipage/forms.html#common-input-element-events BUG=624696 Committed: https://crrev.com/d78434147547eff087c0e9dd249a6ecad3fb486b Cr-Commit-Position: refs/heads/master@{#439386}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/SearchInputType.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
tzik
PTAL
4 years ago (2016-12-18 14:41:00 UTC) #5
haraken
LGTM
4 years ago (2016-12-18 14:54:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580243002/20001
4 years ago (2016-12-18 23:01:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-18 23:05:19 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-18 23:07:13 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d78434147547eff087c0e9dd249a6ecad3fb486b
Cr-Commit-Position: refs/heads/master@{#439386}

Powered by Google App Engine
This is Rietveld 408576698