[Courgette] Simple AssemblyProgram and Disassembler cleanups.

[Courgette] Simple AssemblyProgram and Disassembler cleanups.

We perform mundane cleanups to prepare for next step in
AssemblyProgram reduction:
- Delete dead code (static functions) in AssemblyProgram that were left
  over from LabelManager usage.
- Simplify image_base assignment for AssemblyProgram.
  - Source: Disassembler adds virtual function image_base() (PE file
    reads and stores it; ELF just returns 0).
  - Sink: AssemblyProgram takes it on construction (replaces mutator).
- Disassembler::Disassemble() overrides: Rename |target| to |program|.

BUG=660980
Review-Url: https://codereview.chromium.org/2583373002
Cr-Commit-Position: refs/heads/master@{#443609}
Committed: https://chromium.googlesource.com/chromium/src/+/8563622217956fce69f0eb03ba7f5676d5441824

[huangs, 2016-12-19 22:12:00]

Description was changed from

==========
[Courgette] Clean up AssemblyProgram and Disassembler.

We perform mundane cleanups to prepare for AssemblyProgram reduction:
- Delete dead code (static functions) in AssemblyProgram that were left
  over from LabelManager usage.
- Simplify AssemblyProgram::image_base_ initialization; replaced mutator
  with injection at construction.
- Disassembler::Disassemble() overrides: Rename |target| to |program|.

BUG=660980
==========

to

==========
[Courgette] Simple AssemblyProgram and Disassembler cleanups.

We perform mundane cleanups to prepare for AssemblyProgram reduction:
- Delete dead code (static functions) in AssemblyProgram that were left
  over from LabelManager usage.
- Simplify AssemblyProgram::image_base_ initialization; replaced mutator
  with injection at construction.
- Disassembler::Disassemble() overrides: Rename |target| to |program|.

BUG=660980
==========

[huangs, 2016-12-19 22:17:01]

Description was changed from

==========
[Courgette] Simple AssemblyProgram and Disassembler cleanups.

We perform mundane cleanups to prepare for AssemblyProgram reduction:
- Delete dead code (static functions) in AssemblyProgram that were left
  over from LabelManager usage.
- Simplify AssemblyProgram::image_base_ initialization; replaced mutator
  with injection at construction.
- Disassembler::Disassemble() overrides: Rename |target| to |program|.

BUG=660980
==========

to

==========
[Courgette] Simple AssemblyProgram and Disassembler cleanups.

We perform mundane cleanups to prepare for next step in
AssemblyProgram reduction:
- Delete dead code (static functions) in AssemblyProgram that were left
  over from LabelManager usage.
- Simplify image_base assignment for AssemblyProgram.
  - Source: Disassembler adds virtual function image_base() (PE file
    reads and stores it; ELF just returns 0).
  - Sink: AssemblyProgram takes it on construction (replaces mutator).
- Disassembler::Disassemble() overrides: Rename |target| to |program|.

BUG=660980
==========

[huangs, 2016-12-19 22:17:01]

huangs@chromium.org changed reviewers:
+ wfh@chromium.org

[huangs, 2016-12-19 22:18:43]

The CQ bit was checked by huangs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 22:19:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[huangs, 2016-12-19 22:19:35]

huangs@chromium.org changed reviewers:
+ chrisha@chromium.org

[huangs, 2016-12-19 22:19:35]

Simple clean up; deleted bunch of dead code. PTAL. Thanks!

[commit-bot: I haz the power, 2016-12-19 23:33:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 23:33:46]

Dry run: This issue passed the CQ dry run.

[huangs, 2017-01-05 03:29:05]

Ping for review, PTAL. Thanks!

[huangs, 2017-01-11 21:12:22]

huangs@chromium.org changed reviewers:
+ grt@chromium.org

[huangs, 2017-01-11 21:12:33]

+grt@, PTAL. Thanks!

[Will Harris, 2017-01-11 21:15:35]

sorry for yuuge delay. I am looking at this now.

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
File courgette/disassembler_elf_32.h (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
courgette/disassembler_elf_32.h:107: uint64_t image_base() const override {
return 0; }
why have the image_base in the elf disassembler at all...? Does this just make
the assembly_program code simpler? It seems strange to return 0

[grt (UTC plus 2), 2017-01-12 11:56:41]

just nits from me. cheers.

https://codereview.chromium.org/2583373002/diff/40001/courgette/adjustment_me...
File courgette/adjustment_method_unittest.cc (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/adjustment_me...
courgette/adjustment_method_unittest.cc:11: #include
"base/strings/string_util.h"
unused?

https://codereview.chromium.org/2583373002/diff/40001/courgette/adjustment_me...
courgette/adjustment_method_unittest.cc:39: new AssemblyProgram(EXE_WIN_32_X86,
0x00400000));
nit:
    auto prog = base::MakeUnique<AssemblyProgram>(EXE_WIN_32_X86, 0x00400000);
(and #include "base/memory/ptr_util.h")

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
File courgette/assembly_program.cc (left):

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.cc:344: void
AssemblyProgram::UnassignIndexes(RVAToLabel* labels) {
hooray for code deletion!

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
File courgette/assembly_program.cc (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.cc:7: #include <memory.h>
is this used?

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.cc:8: #include <stddef.h>
std{def,int} are already included in .h

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.cc:11: #include <memory>
already included in .h

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.cc:12: #include <utility>
unused

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.cc:13: #include <vector>
unused

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.cc:16: #include "base/macros.h"
already included in .h

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
File courgette/assembly_program.h (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.h:13: #include <set>
unused

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.h:14: #include <vector>
unused

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.h:16: #include "base/bind.h"
unused

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.h:213: const ExecutableType kind_;
nit: these two data members (although const) belong down after method
declarations as per
https://google.github.io/styleguide/cppguide.html#Declaration_Order

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler.h
File courgette/disassembler.h (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler....
courgette/disassembler.h:8: #include <stddef.h>
is this needed here and elsewhere?

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler....
courgette/disassembler.h:62: RVA PointerToTargetRVA(const uint8_t* p) const = 0;
nit: blank line before this since it isn't part of AddressTranslator

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
File courgette/disassembler_elf_32.cc (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
courgette/disassembler_elf_32.cc:9: #include <utility>
unused?

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
File courgette/disassembler_elf_32_x86_unittest.cc (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
courgette/disassembler_elf_32_x86_unittest.cc:92:
std::unique_ptr<AssemblyProgram> program(
  auto program = base::MakeUnique<...>(...);
(may as well do line 72, too)

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
File courgette/disassembler_win32.cc (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
courgette/disassembler_win32.cc:7: #include <stddef.h>
already included in .h

https://codereview.chromium.org/2583373002/diff/40001/courgette/program_detec...
File courgette/program_detector.cc (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/program_detec...
courgette/program_detector.cc:80: new AssemblyProgram(disassembler->kind(),
disassembler->image_base()));
base::MakeUnique

[huangs, 2017-01-12 19:54:42]

Updated, PTAL. Thanks!

https://codereview.chromium.org/2583373002/diff/40001/courgette/adjustment_me...
File courgette/adjustment_method_unittest.cc (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/adjustment_me...
courgette/adjustment_method_unittest.cc:11: #include
"base/strings/string_util.h"
On 2017/01/12 11:56:40, grt (UTC plus 1) wrote:
> unused?

Removed.

https://codereview.chromium.org/2583373002/diff/40001/courgette/adjustment_me...
courgette/adjustment_method_unittest.cc:39: new AssemblyProgram(EXE_WIN_32_X86,
0x00400000));
On 2017/01/12 11:56:40, grt (UTC plus 1) wrote:
> nit:
>     auto prog = base::MakeUnique<AssemblyProgram>(EXE_WIN_32_X86, 0x00400000);
> (and #include "base/memory/ptr_util.h")

Done.

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
File courgette/assembly_program.cc (left):

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.cc:344: void
AssemblyProgram::UnassignIndexes(RVAToLabel* labels) {
On 2017/01/12 11:56:41, grt (UTC plus 1) wrote:
> hooray for code deletion!

Acknowledged.

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
File courgette/assembly_program.cc (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.cc:7: #include <memory.h>
On 2017/01/12 11:56:41, grt (UTC plus 1) wrote:
> is this used?

Removed.

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.cc:8: #include <stddef.h>
On 2017/01/12 11:56:41, grt (UTC plus 1) wrote:
> std{def,int} are already included in .h

Removed.

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.cc:11: #include <memory>
On 2017/01/12 11:56:41, grt (UTC plus 1) wrote:
> already included in .h

Done.

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.cc:12: #include <utility>
On 2017/01/12 11:56:41, grt (UTC plus 1) wrote:
> unused

Done.

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.cc:13: #include <vector>
On 2017/01/12 11:56:41, grt (UTC plus 1) wrote:
> unused

Done.

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.cc:16: #include "base/macros.h"
On 2017/01/12 11:56:41, grt (UTC plus 1) wrote:
> already included in .h

Done.

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
File courgette/assembly_program.h (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.h:13: #include <set>
On 2017/01/12 11:56:41, grt (UTC plus 1) wrote:
> unused

Done.

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.h:14: #include <vector>
On 2017/01/12 11:56:41, grt (UTC plus 1) wrote:
> unused

Done.

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.h:16: #include "base/bind.h"
On 2017/01/12 11:56:41, grt (UTC plus 1) wrote:
> unused

Need bind.h for base::Callback.

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.h:213: const ExecutableType kind_;
On 2017/01/12 11:56:41, grt (UTC plus 1) wrote:
> nit: these two data members (although const) belong down after method
> declarations as per
> https://google.github.io/styleguide/cppguide.html#Declaration_Order

Done.

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler.h
File courgette/disassembler.h (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler....
courgette/disassembler.h:8: #include <stddef.h>
<stddef.h> for nullptr.
<stdint.h> for uint8_t, etc.

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler....
courgette/disassembler.h:62: RVA PointerToTargetRVA(const uint8_t* p) const = 0;
Actually it is, but I missed the override keyword. Added.

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
File courgette/disassembler_elf_32.cc (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
courgette/disassembler_elf_32.cc:9: #include <utility>
On 2017/01/12 11:56:41, grt (UTC plus 1) wrote:
> unused?

Done.

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
File courgette/disassembler_elf_32.h (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
courgette/disassembler_elf_32.h:107: uint64_t image_base() const override {
return 0; }
I'd rather keep as is for now for this CL. Reason:

In Courgette, data are passed via injection by:

  Disassembler --> AssemblyProgram --> EncodedProgram

where data receiver does not "know" about sender. Now, |image_base| is used by
(1) Win32 Disassembler, (2) EncodedProgram.  Right now |image_base| is passed
from Disassembler to EncodedProgram by using AssemblyProgram as middleman. 
Unfavorable alternatives are:
- Requiring both Disassembler & AssemblyProgram to instantiate EncodedProgram.
- Pass |image_base| via "side band" when intantiating EncodedProgram; this leaks
abstraction for callers.

A potential alternative is to have Disassembler inject |image_base| directly to
EncodedProgram, also as a part of AssemblyProgram reduction. This is beyond the
scope of this CL, which is just simple cleanup.

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
File courgette/disassembler_elf_32_x86_unittest.cc (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
courgette/disassembler_elf_32_x86_unittest.cc:92:
std::unique_ptr<AssemblyProgram> program(
On 2017/01/12 11:56:41, grt (UTC plus 1) wrote:
>   auto program = base::MakeUnique<...>(...);
> (may as well do line 72, too)

Done.

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
File courgette/disassembler_win32.cc (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
courgette/disassembler_win32.cc:7: #include <stddef.h>
On 2017/01/12 11:56:41, grt (UTC plus 1) wrote:
> already included in .h

Done.

https://codereview.chromium.org/2583373002/diff/40001/courgette/program_detec...
File courgette/program_detector.cc (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/program_detec...
courgette/program_detector.cc:80: new AssemblyProgram(disassembler->kind(),
disassembler->image_base()));
On 2017/01/12 11:56:41, grt (UTC plus 1) wrote:
> base::MakeUnique

Done.

[Will Harris, 2017-01-12 19:55:55]

lgtm as a pure refactor

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
File courgette/disassembler_elf_32.h (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
courgette/disassembler_elf_32.h:107: uint64_t image_base() const override {
return 0; }
On 2017/01/12 19:54:42, huangs wrote:
> I'd rather keep as is for now for this CL. Reason:
> 
> In Courgette, data are passed via injection by:
> 
>   Disassembler --> AssemblyProgram --> EncodedProgram
> 
> where data receiver does not "know" about sender. Now, |image_base| is used by
> (1) Win32 Disassembler, (2) EncodedProgram.  Right now |image_base| is passed
> from Disassembler to EncodedProgram by using AssemblyProgram as middleman. 
> Unfavorable alternatives are:
> - Requiring both Disassembler & AssemblyProgram to instantiate EncodedProgram.
> - Pass |image_base| via "side band" when intantiating EncodedProgram; this
leaks
> abstraction for callers.
> 
> A potential alternative is to have Disassembler inject |image_base| directly
to
> EncodedProgram, also as a part of AssemblyProgram reduction. This is beyond
the
> scope of this CL, which is just simple cleanup.

Acknowledged.

[grt (UTC plus 2), 2017-01-13 08:27:33]

lgtm w/ nits

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
File courgette/assembly_program.cc (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.cc:13: #include <vector>
On 2017/01/12 19:54:41, huangs wrote:
> On 2017/01/12 11:56:41, grt (UTC plus 1) wrote:
> > unused
> 
> Done.

This one looks hard to kill! :-)

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
File courgette/assembly_program.h (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.h:16: #include "base/bind.h"
On 2017/01/12 19:54:42, huangs wrote:
> On 2017/01/12 11:56:41, grt (UTC plus 1) wrote:
> > unused
> 
> Need bind.h for base::Callback.

It looks like all you need here is the forward-decl in base/callback_forward.h.
If you really need all of base::Callback defined, please include base/callback.h
rather than base/bind.h.

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler.h
File courgette/disassembler.h (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler....
courgette/disassembler.h:8: #include <stddef.h>
On 2017/01/12 19:54:42, huangs wrote:
> <stddef.h> for nullptr.

nullptr is a keyword, so no headers are needed for it.

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler....
courgette/disassembler.h:62: RVA PointerToTargetRVA(const uint8_t* p) const = 0;
On 2017/01/12 19:54:42, huangs wrote:
> Actually it is, but I missed the override keyword. Added.

Huh. I would have thought you'd have gotten a compile error in that case. Ack.

[huangs, 2017-01-13 16:44:54]

Thanks. Committing soon!

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
File courgette/assembly_program.cc (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.cc:13: #include <vector>
Oh oops! Really removed now.

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
File courgette/assembly_program.h (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/assembly_prog...
courgette/assembly_program.h:16: #include "base/bind.h"
Ah nice! Going with callback_forward.h (include callback.h in .cc file).

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler.h
File courgette/disassembler.h (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler....
courgette/disassembler.h:8: #include <stddef.h>
Ah okay. Removed.

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler....
courgette/disassembler.h:62: RVA PointerToTargetRVA(const uint8_t* p) const = 0;
I thought error would arise if "override" exists, but there's no matching
virtual function in the base class?

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
File courgette/disassembler_elf_32.h (right):

https://codereview.chromium.org/2583373002/diff/40001/courgette/disassembler_...
courgette/disassembler_elf_32.h:107: uint64_t image_base() const override {
return 0; }
On 2017/01/12 19:55:55, Will Harris wrote:
> On 2017/01/12 19:54:42, huangs wrote:
> > I'd rather keep as is for now for this CL. Reason:
> > 
> > In Courgette, data are passed via injection by:
> > 
> >   Disassembler --> AssemblyProgram --> EncodedProgram
> > 
> > where data receiver does not "know" about sender. Now, |image_base| is used
by
> > (1) Win32 Disassembler, (2) EncodedProgram.  Right now |image_base| is
passed
> > from Disassembler to EncodedProgram by using AssemblyProgram as middleman. 
> > Unfavorable alternatives are:
> > - Requiring both Disassembler & AssemblyProgram to instantiate
EncodedProgram.
> > - Pass |image_base| via "side band" when intantiating EncodedProgram; this
> leaks
> > abstraction for callers.
> > 
> > A potential alternative is to have Disassembler inject |image_base| directly
> to
> > EncodedProgram, also as a part of AssemblyProgram reduction. This is beyond
> the
> > scope of this CL, which is just simple cleanup.
> 
> Acknowledged.

Acknowledged.

[huangs, 2017-01-13 16:45:02]

The CQ bit was checked by huangs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 16:45:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 17:34:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 17:34:43]

Dry run: This issue passed the CQ dry run.

[huangs, 2017-01-13 18:03:58]

The CQ bit was checked by huangs@chromium.org

[huangs, 2017-01-13 18:03:59]

The patchset sent to the CQ was uploaded after l-g-t-m from wfh@chromium.org,
grt@chromium.org
Link to the patchset: https://codereview.chromium.org/2583373002/#ps80001
(title: "Tune up header inclusion.")

[commit-bot: I haz the power, 2017-01-13 18:04:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 18:09:17]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484330638835840,
"parent_rev": "534dc4df9756f19cdbd6a2d3fca487019de92830", "commit_rev":
"8563622217956fce69f0eb03ba7f5676d5441824"}

[commit-bot: I haz the power, 2017-01-13 18:09:46]

Description was changed from

==========
[Courgette] Simple AssemblyProgram and Disassembler cleanups.

We perform mundane cleanups to prepare for next step in
AssemblyProgram reduction:
- Delete dead code (static functions) in AssemblyProgram that were left
  over from LabelManager usage.
- Simplify image_base assignment for AssemblyProgram.
  - Source: Disassembler adds virtual function image_base() (PE file
    reads and stores it; ELF just returns 0).
  - Sink: AssemblyProgram takes it on construction (replaces mutator).
- Disassembler::Disassemble() overrides: Rename |target| to |program|.

BUG=660980
==========

to

==========
[Courgette] Simple AssemblyProgram and Disassembler cleanups.

We perform mundane cleanups to prepare for next step in
AssemblyProgram reduction:
- Delete dead code (static functions) in AssemblyProgram that were left
  over from LabelManager usage.
- Simplify image_base assignment for AssemblyProgram.
  - Source: Disassembler adds virtual function image_base() (PE file
    reads and stores it; ELF just returns 0).
  - Sink: AssemblyProgram takes it on construction (replaces mutator).
- Disassembler::Disassemble() overrides: Rename |target| to |program|.

BUG=660980

Review-Url: https://codereview.chromium.org/2583373002
Cr-Commit-Position: refs/heads/master@{#443609}
Committed:
https://chromium.googlesource.com/chromium/src/+/8563622217956fce69f0eb03ba7f...
==========

[commit-bot: I haz the power, 2017-01-13 18:09:50]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8563622217956fce69f0eb03ba7f...