Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: courgette/disassembler.h

Issue 2583373002: [Courgette] Simple AssemblyProgram and Disassembler cleanups. (Closed)
Patch Set: Tune up header inclusion. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « courgette/assembly_program.cc ('k') | courgette/disassembler_elf_32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/disassembler.h
diff --git a/courgette/disassembler.h b/courgette/disassembler.h
index 6a40e873851393e7729195ec00fa094e3bfa77cf..ff2dd692a08c467da00a90ba359ebc0f385f3204 100644
--- a/courgette/disassembler.h
+++ b/courgette/disassembler.h
@@ -5,7 +5,6 @@
#ifndef COURGETTE_DISASSEMBLER_H_
#define COURGETTE_DISASSEMBLER_H_
-#include <stddef.h>
#include <stdint.h>
#include <vector>
@@ -55,14 +54,18 @@ class Disassembler : public AddressTranslator {
virtual ~Disassembler();
// AddressTranslator interfaces.
- virtual RVA FileOffsetToRVA(FileOffset file_offset) const override = 0;
- virtual FileOffset RVAToFileOffset(RVA rva) const override = 0;
+ RVA FileOffsetToRVA(FileOffset file_offset) const override = 0;
+ FileOffset RVAToFileOffset(RVA rva) const override = 0;
const uint8_t* FileOffsetToPointer(FileOffset file_offset) const override;
const uint8_t* RVAToPointer(RVA rva) const override;
- RVA PointerToTargetRVA(const uint8_t* p) const = 0;
+ RVA PointerToTargetRVA(const uint8_t* p) const override = 0;
virtual ExecutableType kind() const = 0;
+ // Returns the preferred image base address. Using uint64_t to accommodate the
+ // general case of 64-bit architectures.
+ virtual uint64_t image_base() const = 0;
+
// Returns a caller-owned new RvaVisitor to iterate through abs32 target RVAs.
virtual RvaVisitor* CreateAbs32TargetRvaVisitor() = 0;
« no previous file with comments | « courgette/assembly_program.cc ('k') | courgette/disassembler_elf_32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698