Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: courgette/program_detector.cc

Issue 2583373002: [Courgette] Simple AssemblyProgram and Disassembler cleanups. (Closed)
Patch Set: Tune up header inclusion. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « courgette/disassembler_win32.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/program_detector.cc
diff --git a/courgette/program_detector.cc b/courgette/program_detector.cc
index 71021cc3f7a397a78457609c223d7cd3e32cf88a..f024a36462f0671d2f25ddd0d034fe4748ac77e8 100644
--- a/courgette/program_detector.cc
+++ b/courgette/program_detector.cc
@@ -6,6 +6,7 @@
#include <utility>
+#include "base/memory/ptr_util.h"
#include "courgette/assembly_program.h"
#include "courgette/disassembler.h"
#include "courgette/disassembler_elf_32_arm.h"
@@ -76,8 +77,8 @@ Status ParseDetectedExecutable(const uint8_t* buffer,
if (!disassembler)
return C_INPUT_NOT_RECOGNIZED;
- std::unique_ptr<AssemblyProgram> program(
- new AssemblyProgram(disassembler->kind()));
+ auto program = base::MakeUnique<AssemblyProgram>(disassembler->kind(),
+ disassembler->image_base());
if (!disassembler->Disassemble(program.get()))
return C_DISASSEMBLY_FAILED;
« no previous file with comments | « courgette/disassembler_win32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698