MD History: Replace last usage of cr-shared-menu with cr-action-menu.

MD History: Replace last usage of cr-shared-menu with cr-action-menu.

 - Remove logic to close menu when scrolling (no longer possible since
   cr-action-menu is a modal <dialog>).
 - Replace "toggle" logic with simpler "open" logic (the menu button can't
   be clicked when the menu is open.
 - Simplify tests that were testing impossible scenarios (open-menu event
   can't fire for a different history entry, while the menu is already open).

BUG=658821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407
Cr-Commit-Position: refs/heads/master@{#440308}

[dpapad, 2016-12-20 01:24:59]

Description was changed from

==========
MD History: Replace last usage of cr-shared-menu with cr-action-menu.

BUG=658821
==========

to

==========
MD History: Replace last usage of cr-shared-menu with cr-action-menu.

BUG=658821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-12-20 01:45:53]

Description was changed from

==========
MD History: Replace last usage of cr-shared-menu with cr-action-menu.

BUG=658821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Replace last usage of cr-shared-menu with cr-action-menu.

 - Remove logic to close menu when scrolling (no longer possible).
 - Replace "toggle" logic with simpler "open" logic (the menu button can't
   be clicked when the menu is open.

BUG=658821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-12-20 01:56:17]

Patchset #1 (id:1) has been deleted

[dpapad, 2016-12-20 01:56:20]

Patchset #1 (id:20001) has been deleted

[dpapad, 2016-12-20 19:09:12]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 19:09:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 19:29:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 19:29:30]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[dpapad, 2016-12-20 22:35:13]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 22:36:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-12-20 22:38:41]

Description was changed from

==========
MD History: Replace last usage of cr-shared-menu with cr-action-menu.

 - Remove logic to close menu when scrolling (no longer possible).
 - Replace "toggle" logic with simpler "open" logic (the menu button can't
   be clicked when the menu is open.

BUG=658821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Replace last usage of cr-shared-menu with cr-action-menu.

 - Remove logic to close menu when scrolling (no longer possible).
 - Replace "toggle" logic with simpler "open" logic (the menu button can't
   be clicked when the menu is open.
 - Simplify tests that were testing impossible scenarios (open-menu event
   can't fire for a different history entry, while the menu is already open).

BUG=658821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-12-20 22:42:25]

Description was changed from

==========
MD History: Replace last usage of cr-shared-menu with cr-action-menu.

 - Remove logic to close menu when scrolling (no longer possible).
 - Replace "toggle" logic with simpler "open" logic (the menu button can't
   be clicked when the menu is open.
 - Simplify tests that were testing impossible scenarios (open-menu event
   can't fire for a different history entry, while the menu is already open).

BUG=658821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Replace last usage of cr-shared-menu with cr-action-menu.

 - Remove logic to close menu when scrolling (no longer possible since
   cr-action-menu is a modal <dialog>).
 - Replace "toggle" logic with simpler "open" logic (the menu button can't
   be clicked when the menu is open.
 - Simplify tests that were testing impossible scenarios (open-menu event
   can't fire for a different history entry, while the menu is already open).

BUG=658821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-12-20 23:35:20]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org, tsergeant@chromium.org

[tsergeant, 2016-12-21 00:39:36]

Thanks for doing this! It deletes a bunch of code and fixes a bunch of bugs at
the same time.

My one general comment is that since this changes the appearance a bit, we
should make sure that Alan is happy with it (once he's back from holiday) before
it starts making its way out to beta/stable.

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
File chrome/browser/resources/md_history/list_container.html (right):

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
chrome/browser/resources/md_history/list_container.html:4: <link rel="import"
href="chrome://resources/cr_elements/cr_action_menu/cr_action_menu.html">
This should be lazy loaded, which means that the import lives in lazy_load.html
instead of here (and the comment below on line 11 keeps track of that).

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
File chrome/browser/resources/md_history/shared_style.html (right):

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_style.html:40: /* TODO(dpapad):
Copied from MD Settings, find a way to re-use style. */
Can it be moved into cr_elements/shared_style_css.html ? This was what we did
for cr-dialog, and it shouldn't require any changes to the usage in settings.

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_manager.js (right):

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_manager.js:138: var menu = /**
@type {CrSharedMenuElement} */ this.$.menu.get();
CrActionMenuElement, now

(it's weird that closure didn't complain about this =S)

https://codereview.chromium.org/2583353003/diff/70001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_overflow_menu_test.js (right):

https://codereview.chromium.org/2583353003/diff/70001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_overflow_menu_test.js:25:
test('opening and closing menu', function() {
The existence of this test at all is a relic from the days before cr-shared-menu
was pulled out of MD History. I'm not sure it actually tests anything useful any
more, so I'm happy for you to delete it entirely if you agree.

[dpapad, 2016-12-21 01:04:49]

I am fine with waiting for Alan to approve. Having said that, we do want our MD
pages to look consistent, and the style after this CL lands will be matching
Settings' style for action menus, so probably Alan will agree.

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
File chrome/browser/resources/md_history/list_container.html (right):

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
chrome/browser/resources/md_history/list_container.html:4: <link rel="import"
href="chrome://resources/cr_elements/cr_action_menu/cr_action_menu.html">
On 2016/12/21 at 00:39:36, tsergeant wrote:
> This should be lazy loaded, which means that the import lives in
lazy_load.html instead of here (and the comment below on line 11 keeps track of
that).

Done. Thanks for the explanation, I was wondering why the cr-shared-menu dep was
missing from here (and also I just re-inforced what we already know, devs don't
always read comments :>)

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
File chrome/browser/resources/md_history/shared_style.html (right):

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_style.html:40: /* TODO(dpapad):
Copied from MD Settings, find a way to re-use style. */
On 2016/12/21 at 00:39:36, tsergeant wrote:
> Can it be moved into cr_elements/shared_style_css.html ? This was what we did
for cr-dialog, and it shouldn't require any changes to the usage in settings.

cr_elements/shared_style_css.html sounds better than copying the styles here. Or
even baking those into cr_action_menu itself at
https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_action...

Don't have a strong opinion. @dbeam, thoughts?

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_manager.js (right):

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_manager.js:138: var menu = /**
@type {CrSharedMenuElement} */ this.$.menu.get();
On 2016/12/21 at 00:39:36, tsergeant wrote:
> CrActionMenuElement, now
> 
> (it's weird that closure didn't complain about this =S)

Done, and yes, something is fishy. Closure should have caught that (this file
has an equivalent compile target in compiled_resources2.gyp).

https://codereview.chromium.org/2583353003/diff/70001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_overflow_menu_test.js (right):

https://codereview.chromium.org/2583353003/diff/70001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_overflow_menu_test.js:25:
test('opening and closing menu', function() {
On 2016/12/21 at 00:39:36, tsergeant wrote:
> The existence of this test at all is a relic from the days before
cr-shared-menu was pulled out of MD History. I'm not sure it actually tests
anything useful any more, so I'm happy for you to delete it entirely if you
agree.

This test is accessing a lot of private state, like actionMenuModel_/lastAnchor,
and before this change toggleMenu_ (switched to firing an event here). I still
think there is a small value added by this test, since it ensures that
listContainer responds to the open-menu event fired from its children. I say
let's keep it, but perhaps improve the assertions (in a follow up CL) to not
query private state.

[tsergeant, 2016-12-21 02:37:34]

To be clear, I'm happy for this to land now and for any design nits that are
needed to come after.

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
File chrome/browser/resources/md_history/shared_style.html (right):

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_style.html:40: /* TODO(dpapad):
Copied from MD Settings, find a way to re-use style. */
On 2016/12/21 01:04:48, dpapad wrote:
> On 2016/12/21 at 00:39:36, tsergeant wrote:
> > Can it be moved into cr_elements/shared_style_css.html ? This was what we
did
> for cr-dialog, and it shouldn't require any changes to the usage in settings.
> 
> cr_elements/shared_style_css.html sounds better than copying the styles here.
Or
> even baking those into cr_action_menu itself at
>
https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_action...
> 
> Don't have a strong opinion. @dbeam, thoughts?

Hmm, yeah, if there's nothing in settings that uses the styles outside of a
cr-action-menu, then baking them directly into the element probably makes the
most sense.

https://codereview.chromium.org/2583353003/diff/70001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_overflow_menu_test.js (right):

https://codereview.chromium.org/2583353003/diff/70001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_overflow_menu_test.js:25:
test('opening and closing menu', function() {
On 2016/12/21 01:04:48, dpapad wrote:
> On 2016/12/21 at 00:39:36, tsergeant wrote:
> > The existence of this test at all is a relic from the days before
> cr-shared-menu was pulled out of MD History. I'm not sure it actually tests
> anything useful any more, so I'm happy for you to delete it entirely if you
> agree.
> 
> This test is accessing a lot of private state, like
actionMenuModel_/lastAnchor,
> and before this change toggleMenu_ (switched to firing an event here). I still
> think there is a small value added by this test, since it ensures that
> listContainer responds to the open-menu event fired from its children. I say
> let's keep it, but perhaps improve the assertions (in a follow up CL) to not
> query private state.

sgtm

[Dan Beam, 2016-12-21 03:11:19]

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
File chrome/browser/resources/md_history/shared_style.html (right):

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_style.html:40: /* TODO(dpapad):
Copied from MD Settings, find a way to re-use style. */
On 2016/12/21 02:37:34, tsergeant wrote:
> On 2016/12/21 01:04:48, dpapad wrote:
> > On 2016/12/21 at 00:39:36, tsergeant wrote:
> > > Can it be moved into cr_elements/shared_style_css.html ? This was what we
> did
> > for cr-dialog, and it shouldn't require any changes to the usage in
settings.
> > 
> > cr_elements/shared_style_css.html sounds better than copying the styles
here.
> Or
> > even baking those into cr_action_menu itself at
> >
>
https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_action...
> > 
> > Don't have a strong opinion. @dbeam, thoughts?
> 
> Hmm, yeah, if there's nothing in settings that uses the styles outside of a
> cr-action-menu, then baking them directly into the element probably makes the
> most sense.

yes, i'd move the default dropdown-item (and hr) styling to cr_action_menu.html

[dpapad, 2016-12-21 03:50:18]

Moved styling PTAL.

Also note, cr-action-menu has many advantages over previous implementations
(cr-shared-menu, iron-dropdown), but it suffers from two getBoundingClientRect
(minor) bugs, I am hoping they will get fixed eventually.

https://bugs.chromium.org/p/chromium/issues/detail?id=667198
https://bugs.chromium.org/p/chromium/issues/detail?id=662300

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
File chrome/browser/resources/md_history/shared_style.html (right):

https://codereview.chromium.org/2583353003/diff/70001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_style.html:40: /* TODO(dpapad):
Copied from MD Settings, find a way to re-use style. */
> yes, i'd move the default dropdown-item (and hr) styling to
cr_action_menu.html

Done for dropdown-item. Did not move hr styling because it is only used in one
place
(https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/langua...)
and it is using CSS classes that are specific to that use case (see 'complex'
css class).

[tsergeant, 2016-12-21 04:22:21]

lgtm, hopefully having cr-action-menu launched in history will give some more
weight to those bugs.

[dpapad, 2016-12-21 18:27:17]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 18:27:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 18:30:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 18:30:27]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[dpapad, 2016-12-21 20:23:02]

On 2016/12/21 at 04:22:21, tsergeant wrote:
> lgtm, hopefully having cr-action-menu launched in history will give some more
weight to those bugs.

Ping @dbeam. In the meantime, resolving conflicts with
https://codereview.chromium.org/2578013002.

[dpapad, 2016-12-21 21:35:44]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 21:36:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-12-21 22:06:38]

lgtm

https://codereview.chromium.org/2583353003/diff/130001/chrome/browser/resourc...
File chrome/browser/resources/md_history/list_container.js (right):

https://codereview.chromium.org/2583353003/diff/130001/chrome/browser/resourc...
chrome/browser/resources/md_history/list_container.js:30: *    path: string,
target: !HTMLElement
indent off, why are you wrapping like this?

[commit-bot: I haz the power, 2016-12-21 22:25:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 22:25:03]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dpapad, 2016-12-21 22:41:09]

https://codereview.chromium.org/2583353003/diff/130001/chrome/browser/resourc...
File chrome/browser/resources/md_history/list_container.js (right):

https://codereview.chromium.org/2583353003/diff/130001/chrome/browser/resourc...
chrome/browser/resources/md_history/list_container.js:30: *    path: string,
target: !HTMLElement
On 2016/12/21 at 22:06:38, Dan Beam wrote:
> indent off, why are you wrapping like this?

Done. If only there was a linter to tell me how to do this (and that also
operated on JSDoc)

[dpapad, 2016-12-21 22:45:59]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-12-21 22:46:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2583353003/#ps150001
(title: "Nit")

[commit-bot: I haz the power, 2016-12-21 22:46:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 23:45:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 23:45:27]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dpapad, 2016-12-22 00:14:21]

https://codereview.chromium.org/2583353003/diff/150001/ui/webui/resources/cr_...
File ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html (right):

https://codereview.chromium.org/2583353003/diff/150001/ui/webui/resources/cr_...
ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html:1: <link
rel="import" href="chrome://resources/cr_elements/shared_vars_css.html">
This change causes a "Polymer is already defined." error during unit tests. I am
investigating...

[dpapad, 2016-12-22 00:46:18]

https://codereview.chromium.org/2583353003/diff/150001/ui/webui/resources/cr_...
File ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html (right):

https://codereview.chromium.org/2583353003/diff/150001/ui/webui/resources/cr_...
ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html:1: <link
rel="import" href="chrome://resources/cr_elements/shared_vars_css.html">
On 2016/12/22 at 00:14:21, dpapad wrote:
> This change causes a "Polymer is already defined." error during unit tests. I
am investigating...

Fixed. It turns out that polymer.html must be at the top. This revealed a follow
up error which i fixed below.

https://codereview.chromium.org/2583353003/diff/150001/ui/webui/resources/cr_...
ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html:34: :host
::content .dropdown-item:not([disabled]) {
Subtle bug that was caught by a test! hidden attribute was overriden by the
:host ::content .dropdown-item display: flex rule (which made a hidden option
not actually hidden), so I had to move it here.

[dpapad, 2016-12-22 00:46:55]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-12-22 00:46:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2583353003/#ps170001
(title: "Test found real subtle bug (display flex overriding [hidden]
attribute)")

[commit-bot: I haz the power, 2016-12-22 00:47:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 01:51:55]

CQ is committing da patch.

Bot data: {"patchset_id": 170001, "attempt_start_ts": 1482367615837000,
"parent_rev": "12e1adeb84cbdde6e4788fa9bf191d1633bb5d3b", "commit_rev":
"e2c73ea66eae7fdd773ff3d1ca843b02616424ea"}

[commit-bot: I haz the power, 2016-12-22 01:52:24]

Description was changed from

==========
MD History: Replace last usage of cr-shared-menu with cr-action-menu.

 - Remove logic to close menu when scrolling (no longer possible since
   cr-action-menu is a modal <dialog>).
 - Replace "toggle" logic with simpler "open" logic (the menu button can't
   be clicked when the menu is open.
 - Simplify tests that were testing impossible scenarios (open-menu event
   can't fire for a different history entry, while the menu is already open).

BUG=658821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Replace last usage of cr-shared-menu with cr-action-menu.

 - Remove logic to close menu when scrolling (no longer possible since
   cr-action-menu is a modal <dialog>).
 - Replace "toggle" logic with simpler "open" logic (the menu button can't
   be clicked when the menu is open.
 - Simplify tests that were testing impossible scenarios (open-menu event
   can't fire for a different history entry, while the menu is already open).

BUG=658821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2583353003
==========

[commit-bot: I haz the power, 2016-12-22 01:52:26]

Committed patchset #8 (id:170001)

[commit-bot: I haz the power, 2016-12-22 01:54:45]

Description was changed from

==========
MD History: Replace last usage of cr-shared-menu with cr-action-menu.

 - Remove logic to close menu when scrolling (no longer possible since
   cr-action-menu is a modal <dialog>).
 - Replace "toggle" logic with simpler "open" logic (the menu button can't
   be clicked when the menu is open.
 - Simplify tests that were testing impossible scenarios (open-menu event
   can't fire for a different history entry, while the menu is already open).

BUG=658821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2583353003
==========

to

==========
MD History: Replace last usage of cr-shared-menu with cr-action-menu.

 - Remove logic to close menu when scrolling (no longer possible since
   cr-action-menu is a modal <dialog>).
 - Replace "toggle" logic with simpler "open" logic (the menu button can't
   be clicked when the menu is open.
 - Simplify tests that were testing impossible scenarios (open-menu event
   can't fire for a different history entry, while the menu is already open).

BUG=658821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407
Cr-Commit-Position: refs/heads/master@{#440308}
==========

[commit-bot: I haz the power, 2016-12-22 01:54:47]

Patchset 8 (id:??) landed as
https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407
Cr-Commit-Position: refs/heads/master@{#440308}