Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8731)

Unified Diff: chrome/test/data/webui/md_history/history_metrics_test.js

Issue 2583353003: MD History: Replace last usage of cr-shared-menu with cr-action-menu. (Closed)
Patch Set: Test found real subtle bug (display flex overriding [hidden] attribute) Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/md_history/history_metrics_test.js
diff --git a/chrome/test/data/webui/md_history/history_metrics_test.js b/chrome/test/data/webui/md_history/history_metrics_test.js
index c9c6e80eb3605364becc6b94f1c4ec33ebf3efaa..a708454b026dc3e3e3ad3298b2e784dd47830f20 100644
--- a/chrome/test/data/webui/md_history/history_metrics_test.js
+++ b/chrome/test/data/webui/md_history/history_metrics_test.js
@@ -151,6 +151,7 @@ suite('Metrics', function() {
test('synced-device-manager', function() {
app.selectedPage_ = 'syncedTabs';
var histogram;
+ var menuButton;
return PolymerTest.flushTasks().then(() => {
histogram = histogramMap[SYNCED_TABS_HISTOGRAM_NAME];
assertEquals(1, histogram[SyncedTabsHistogram.INITIALIZED]);
@@ -183,12 +184,16 @@ suite('Metrics', function() {
MockInteractions.tap(polymerSelectAll(cards[0], '.website-title')[0]);
assertEquals(1, histogram[SyncedTabsHistogram.LINK_CLICKED]);
- MockInteractions.tap(cards[0].$['menu-button']);
+ menuButton = cards[0].$['menu-button'];
+ MockInteractions.tap(menuButton);
return PolymerTest.flushTasks();
}).then(() => {
MockInteractions.tap(app.$$('#synced-devices').$$('#menuOpenButton'));
assertEquals(1, histogram[SyncedTabsHistogram.OPEN_ALL]);
+ MockInteractions.tap(menuButton);
+ return PolymerTest.flushTasks();
+ }).then(() => {
MockInteractions.tap(app.$$('#synced-devices').$$('#menuDeleteButton'));
assertEquals(1, histogram[SyncedTabsHistogram.HIDE_FOR_NOW]);
});

Powered by Google App Engine
This is Rietveld 408576698