Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2578013002: [MD History] clang-format all javascript. (Closed)

Created:
4 years ago by calamity
Modified:
4 years ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] clang-format all javascript. This CL clang-formats all of the javascript in MD History which will serve as a basis for a tidier, more consistent future. It also moves simple properties to an alphabetized list at the bottom of the properties object for parsability. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/1ea056e8023345b390c455d8f31af9fccd810106 Cr-Commit-Position: refs/heads/master@{#440059}

Patch Set 1 : #

Patch Set 2 : debase #

Patch Set 3 : debase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -193 lines) Patch
M chrome/browser/resources/md_history/app.js View 7 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/resources/md_history/app.crisper.js View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 2 3 6 chunks +38 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/browser_service.js View 5 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/resources/md_history/constants.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/grouped_list.js View 2 chunks +11 lines, -18 lines 0 comments Download
M chrome/browser/resources/md_history/history.js View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_history/history_item.js View 5 chunks +38 lines, -25 lines 0 comments Download
M chrome/browser/resources/md_history/history_list.js View 4 chunks +9 lines, -13 lines 0 comments Download
M chrome/browser/resources/md_history/history_list_behavior.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_toolbar.js View 1 4 chunks +17 lines, -6 lines 0 comments Download
M chrome/browser/resources/md_history/lazy_load.crisper.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/lazy_load.vulcanized.html View 1 2 3 3 chunks +15 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/list_container.js View 7 chunks +35 lines, -37 lines 0 comments Download
M chrome/browser/resources/md_history/router.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/searched_label.js View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_history/side_bar.js View 4 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_card.js View 6 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_manager.js View 4 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 28 (19 generated)
calamity
clang-format is love, clang-format is life.
4 years ago (2016-12-15 06:19:56 UTC) #6
Dan Beam
do you want to do this on the generated code?
4 years ago (2016-12-15 06:33:17 UTC) #8
calamity
On 2016/12/15 06:33:17, Dan Beam wrote: > do you want to do this on the ...
4 years ago (2016-12-15 06:45:06 UTC) #9
tsergeant
🆒🆒🆒 lgtm
4 years ago (2016-12-15 23:15:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578013002/100001
4 years ago (2016-12-20 03:21:07 UTC) #18
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/md_history/app.vulcanized.html: While running git apply --index -p1; <stdin>:27: trailing whitespace. ...
4 years ago (2016-12-20 05:13:02 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578013002/140001
4 years ago (2016-12-21 06:34:25 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:140001)
4 years ago (2016-12-21 09:01:11 UTC) #26
commit-bot: I haz the power
4 years ago (2016-12-21 09:05:16 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/1ea056e8023345b390c455d8f31af9fccd810106
Cr-Commit-Position: refs/heads/master@{#440059}

Powered by Google App Engine
This is Rietveld 408576698