Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2585073002: Specify TaskType of posted Task explicitly in DataTransferItem (1) (Closed)

Created:
4 years ago by tzik
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, dcheng, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify TaskType of posted Task explicitly in DataTransferItem This CL specifies the TaskType of a task posted by DataTransferItem as UserInteraction, instead of using the default Unspecified TaskType. The spec does not specify this explicitly, but TaskType::UserInteraction should be the best fit here. https://html.spec.whatwg.org/multipage/interaction.html#dom-datatransferitem-getasstring BUG=624696 Committed: https://crrev.com/1306e6ee017c79e20d8b6e96d713a03c5ea9cdea Cr-Commit-Position: refs/heads/master@{#439378}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp View 2 chunks +3 lines, -1 line 2 comments Download
M third_party/WebKit/Source/core/dom/StringCallback.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StringCallback.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (14 generated)
tzik
PTAL
4 years ago (2016-12-18 13:07:35 UTC) #9
haraken
LGTM with a comment. https://codereview.chromium.org/2585073002/diff/1/third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp File third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp (right): https://codereview.chromium.org/2585073002/diff/1/third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp#newcode75 third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp:75: StringCallback::scheduleCallback(TaskType::UserInteraction, callback, context, It looks ...
4 years ago (2016-12-18 13:30:30 UTC) #12
tzik
https://codereview.chromium.org/2585073002/diff/1/third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp File third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp (right): https://codereview.chromium.org/2585073002/diff/1/third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp#newcode75 third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp:75: StringCallback::scheduleCallback(TaskType::UserInteraction, callback, context, On 2016/12/18 13:30:30, haraken wrote: > ...
4 years ago (2016-12-18 21:44:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585073002/1
4 years ago (2016-12-18 21:44:46 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-18 21:48:33 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-18 21:50:05 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1306e6ee017c79e20d8b6e96d713a03c5ea9cdea
Cr-Commit-Position: refs/heads/master@{#439378}

Powered by Google App Engine
This is Rietveld 408576698