Specify TaskType of posted Task explicitly in DataTransferItem (1)

Specify TaskType of posted Task explicitly in DataTransferItem

This CL specifies the TaskType of a task posted by DataTransferItem as
UserInteraction, instead of using the default Unspecified TaskType.
The spec does not specify this explicitly, but TaskType::UserInteraction
should be the best fit here.
https://html.spec.whatwg.org/multipage/interaction.html#dom-datatransferitem-getasstring

BUG=624696
Committed: https://crrev.com/1306e6ee017c79e20d8b6e96d713a03c5ea9cdea
Cr-Commit-Position: refs/heads/master@{#439378}

[tzik, 2016-12-18 11:25:17]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-18 11:25:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-12-18 11:36:56]

Description was changed from

==========
Specify TaskType of posted Task explicitly in DataTransferItem

BUG=
==========

to

==========
Specify TaskType of posted Task explicitly in DataTransferItem

123456789012345678901234567890123456789012345678901234567890123456789012

This CL specifies the TaskType of a task posted by DataTransferItem as
UserInteraction, instead of using the default Unspecified TaskType.
The spec does not specify this explicitly, but TaskType::UserInteraction
should be the best fit here.
https://html.spec.whatwg.org/multipage/interaction.html#dom-datatransferitem-...
==========

[tzik, 2016-12-18 11:37:04]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-18 11:37:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-12-18 11:37:37]

Description was changed from

==========
Specify TaskType of posted Task explicitly in DataTransferItem

123456789012345678901234567890123456789012345678901234567890123456789012

This CL specifies the TaskType of a task posted by DataTransferItem as
UserInteraction, instead of using the default Unspecified TaskType.
The spec does not specify this explicitly, but TaskType::UserInteraction
should be the best fit here.
https://html.spec.whatwg.org/multipage/interaction.html#dom-datatransferitem-...
==========

to

==========
Specify TaskType of posted Task explicitly in DataTransferItem

This CL specifies the TaskType of a task posted by DataTransferItem as
UserInteraction, instead of using the default Unspecified TaskType.
The spec does not specify this explicitly, but TaskType::UserInteraction
should be the best fit here.
https://html.spec.whatwg.org/multipage/interaction.html#dom-datatransferitem-...
==========

[tzik, 2016-12-18 13:06:21]

tzik@chromium.org changed reviewers:
+ haraken@chromium.org

[tzik, 2016-12-18 13:07:19]

Description was changed from

==========
Specify TaskType of posted Task explicitly in DataTransferItem

This CL specifies the TaskType of a task posted by DataTransferItem as
UserInteraction, instead of using the default Unspecified TaskType.
The spec does not specify this explicitly, but TaskType::UserInteraction
should be the best fit here.
https://html.spec.whatwg.org/multipage/interaction.html#dom-datatransferitem-...
==========

to

==========
Specify TaskType of posted Task explicitly in DataTransferItem

This CL specifies the TaskType of a task posted by DataTransferItem as
UserInteraction, instead of using the default Unspecified TaskType.
The spec does not specify this explicitly, but TaskType::UserInteraction
should be the best fit here.
https://html.spec.whatwg.org/multipage/interaction.html#dom-datatransferitem-...

BUG=624696
==========

[tzik, 2016-12-18 13:07:35]

PTAL

[commit-bot: I haz the power, 2016-12-18 13:16:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-18 13:16:15]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-12-18 13:30:30]

LGTM with a comment.

https://codereview.chromium.org/2585073002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp (right):

https://codereview.chromium.org/2585073002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp:75:
StringCallback::scheduleCallback(TaskType::UserInteraction, callback, context,

It looks like StringCallback is used only here. Maybe can we inline the method
here?

[tzik, 2016-12-18 21:44:26]

https://codereview.chromium.org/2585073002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp (right):

https://codereview.chromium.org/2585073002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp:75:
StringCallback::scheduleCallback(TaskType::UserInteraction, callback, context,
On 2016/12/18 13:30:30, haraken wrote:
> 
> It looks like StringCallback is used only here. Maybe can we inline the method
> here?

Yes, we can. Let me do it in a separate CL.

[tzik, 2016-12-18 21:44:34]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2016-12-18 21:44:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-18 21:48:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482097474227810, "parent_rev":
"7dea2c4c06d9c1ad2e3536e753183b05e6466aa0", "commit_rev":
"a8a278d55201f98a145774eefb7a0d555d61ce4d"}

[commit-bot: I haz the power, 2016-12-18 21:48:32]

Description was changed from

==========
Specify TaskType of posted Task explicitly in DataTransferItem

This CL specifies the TaskType of a task posted by DataTransferItem as
UserInteraction, instead of using the default Unspecified TaskType.
The spec does not specify this explicitly, but TaskType::UserInteraction
should be the best fit here.
https://html.spec.whatwg.org/multipage/interaction.html#dom-datatransferitem-...

BUG=624696
==========

to

==========
Specify TaskType of posted Task explicitly in DataTransferItem

This CL specifies the TaskType of a task posted by DataTransferItem as
UserInteraction, instead of using the default Unspecified TaskType.
The spec does not specify this explicitly, but TaskType::UserInteraction
should be the best fit here.
https://html.spec.whatwg.org/multipage/interaction.html#dom-datatransferitem-...

BUG=624696

Review-Url: https://codereview.chromium.org/2585073002
==========

[commit-bot: I haz the power, 2016-12-18 21:48:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-18 21:50:04]

Description was changed from

==========
Specify TaskType of posted Task explicitly in DataTransferItem

This CL specifies the TaskType of a task posted by DataTransferItem as
UserInteraction, instead of using the default Unspecified TaskType.
The spec does not specify this explicitly, but TaskType::UserInteraction
should be the best fit here.
https://html.spec.whatwg.org/multipage/interaction.html#dom-datatransferitem-...

BUG=624696

Review-Url: https://codereview.chromium.org/2585073002
==========

to

==========
Specify TaskType of posted Task explicitly in DataTransferItem

This CL specifies the TaskType of a task posted by DataTransferItem as
UserInteraction, instead of using the default Unspecified TaskType.
The spec does not specify this explicitly, but TaskType::UserInteraction
should be the best fit here.
https://html.spec.whatwg.org/multipage/interaction.html#dom-datatransferitem-...

BUG=624696

Committed: https://crrev.com/1306e6ee017c79e20d8b6e96d713a03c5ea9cdea
Cr-Commit-Position: refs/heads/master@{#439378}
==========

[commit-bot: I haz the power, 2016-12-18 21:50:05]

Patchset 1 (id:??) landed as
https://crrev.com/1306e6ee017c79e20d8b6e96d713a03c5ea9cdea
Cr-Commit-Position: refs/heads/master@{#439378}