Remove obsolete app_list Linux code.

Remove obsolete app_list Linux code.

Also removes other app_list files that are no longer used due to having
removed app_list on non-Chrome-OS platforms.

BUG=614575
Committed: https://crrev.com/b21a894a060c42ae2c216032317063f44694f86a
Cr-Commit-Position: refs/heads/master@{#440248}

[Matt Giuca, 2016-12-16 04:55:48]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 04:56:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Matt Giuca, 2016-12-16 04:59:39]

mgiuca@chromium.org changed reviewers:
+ tapted@chromium.org

[tapted, 2016-12-16 05:11:41]

WDYT of removing ProfileLoader per http://crbug.com/614575#c12 ? (in a follow-up
perhaps)

https://codereview.chromium.org/2582743002/diff/20001/chrome/browser/apps/cus...
File chrome/browser/apps/custom_launcher_page_browsertest_views.cc (right):

https://codereview.chromium.org/2582743002/diff/20001/chrome/browser/apps/cus...
chrome/browser/apps/custom_launcher_page_browsertest_views.cc:211: // Gesture
events need to be in host coordinates. On Desktop platforms, the
nit: remove "On Desktop platforms.." sentence?

https://codereview.chromium.org/2582743002/diff/20001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2582743002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:2554:
"../browser/ui/app_list/app_list_controller_browsertest.cc",
There are some #if (OS_CHROMEOS) in here

https://codereview.chromium.org/2582743002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:2555:
"../browser/ui/app_list/app_list_service_impl_browsertest.cc",
There are lots (more)  #if (OS_CHROMEOS) in this file

https://codereview.chromium.org/2582743002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:4828:
"../browser/ui/app_list/app_list_service_unittest.cc",
This has some profile switching stuff that will probably come out in the wash
with ProfileLoader being purged

https://codereview.chromium.org/2582743002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:4841: "../browser/ui/app_list/test/fake_profile_store.h",
All the fake_profile goop probably isn't needed either

https://codereview.chromium.org/2582743002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:4845: if (enable_app_list && is_chromeos) {
I guess this can be simplified in a follow-up?

[commit-bot: I haz the power, 2016-12-16 07:06:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 07:06:26]

Dry run: This issue passed the CQ dry run.

[Matt Giuca, 2016-12-21 06:18:03]

Yeah, let's remove ProfileLoader in a follow-up.

https://codereview.chromium.org/2582743002/diff/20001/chrome/browser/apps/cus...
File chrome/browser/apps/custom_launcher_page_browsertest_views.cc (right):

https://codereview.chromium.org/2582743002/diff/20001/chrome/browser/apps/cus...
chrome/browser/apps/custom_launcher_page_browsertest_views.cc:211: // Gesture
events need to be in host coordinates. On Desktop platforms, the
On 2016/12/16 05:11:41, tapted wrote:
> nit: remove "On Desktop platforms.." sentence?

Done.

https://codereview.chromium.org/2582743002/diff/20001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2582743002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:2554:
"../browser/ui/app_list/app_list_controller_browsertest.cc",
On 2016/12/16 05:11:41, tapted wrote:
> There are some #if (OS_CHROMEOS) in here

Done.

https://codereview.chromium.org/2582743002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:2555:
"../browser/ui/app_list/app_list_service_impl_browsertest.cc",
On 2016/12/16 05:11:41, tapted wrote:
> There are lots (more)  #if (OS_CHROMEOS) in this file

Done.

https://codereview.chromium.org/2582743002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:4828:
"../browser/ui/app_list/app_list_service_unittest.cc",
On 2016/12/16 05:11:41, tapted wrote:
> This has some profile switching stuff that will probably come out in the wash
> with ProfileLoader being purged

Acknowledged.

https://codereview.chromium.org/2582743002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:4841: "../browser/ui/app_list/test/fake_profile_store.h",
On 2016/12/16 05:11:41, tapted wrote:
> All the fake_profile goop probably isn't needed either

Acknowledged.

https://codereview.chromium.org/2582743002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:4845: if (enable_app_list && is_chromeos) {
On 2016/12/16 05:11:41, tapted wrote:
> I guess this can be simplified in a follow-up?

Done here.

[Matt Giuca, 2016-12-21 06:26:52]

Patchset #3 (id:40001) has been deleted

[tapted, 2016-12-21 10:24:29]

The CQ bit was checked by tapted@chromium.org

[tapted, 2016-12-21 10:24:30]

lgtm

[commit-bot: I haz the power, 2016-12-21 10:24:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 10:31:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 10:31:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tapted, 2016-12-21 11:23:02]

https://codereview.chromium.org/2582743002/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/app_list/OWNERS (left):

https://codereview.chromium.org/2582743002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/app_list/OWNERS:4: tapted@chromium.org
lol. I think we need to leave this file here in order to land without getting a
higher level owner. https://www.youtube.com/watch?v=lrfhf1Gv4Tw

[tapted, 2016-12-21 11:27:33]

tapted@chromium.org changed reviewers:
+ pkasting@chromium.org

[tapted, 2016-12-21 11:27:34]

+pkasting for OWNERS, to delete a folder:

chrome/browser/ui/views/app_list

(turns out having OWNERS in a folder doesn't let you delete the OWNERS file in
that folder - I guess that make sense)

(matt is OOO, so I'll land on his behalf if there are no issues, otherwise it
can wait)

[Peter Kasting, 2016-12-21 20:09:49]

RS LGTM

[tapted, 2016-12-21 21:53:57]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-12-21 21:54:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 22:44:13]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1482357237867670,
"parent_rev": "af59d7d8b91feadeb06dd39d616d8b0f3594ad13", "commit_rev":
"720cd69ba97582b13fb9593986a838685460f753"}

[commit-bot: I haz the power, 2016-12-21 22:44:40]

Description was changed from

==========
Remove obsolete app_list Linux code.

Also removes other app_list files that are no longer used due to having
removed app_list on non-Chrome-OS platforms.

BUG=614575
==========

to

==========
Remove obsolete app_list Linux code.

Also removes other app_list files that are no longer used due to having
removed app_list on non-Chrome-OS platforms.

BUG=614575

Review-Url: https://codereview.chromium.org/2582743002
==========

[commit-bot: I haz the power, 2016-12-21 22:44:41]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-12-21 22:48:25]

Description was changed from

==========
Remove obsolete app_list Linux code.

Also removes other app_list files that are no longer used due to having
removed app_list on non-Chrome-OS platforms.

BUG=614575

Review-Url: https://codereview.chromium.org/2582743002
==========

to

==========
Remove obsolete app_list Linux code.

Also removes other app_list files that are no longer used due to having
removed app_list on non-Chrome-OS platforms.

BUG=614575

Committed: https://crrev.com/b21a894a060c42ae2c216032317063f44694f86a
Cr-Commit-Position: refs/heads/master@{#440248}
==========

[commit-bot: I haz the power, 2016-12-21 22:48:25]

Patchset 4 (id:??) landed as
https://crrev.com/b21a894a060c42ae2c216032317063f44694f86a
Cr-Commit-Position: refs/heads/master@{#440248}