s390x: implement vector support on s390

s390x: implement vector support on s390

Add vfa/vfs/vfm/vfd support on s390

R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com, danno@chromium.org, jkummerow@chromium.org, jochen@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2582683002
Cr-Commit-Position: refs/heads/master@{#41741}
Committed: https://chromium.googlesource.com/v8/v8/+/efd92a1659a6aa1964d12cdda67946ce9b2f6461

[john.yan, 2016-12-16 01:00:55]

Description was changed from

==========
s390x: implement vector support on s390

Add vfa/vfs/vfm/vfd support on s390

R==joransiu@ca.ibm.com, bjaideep@ca.ibm.com, danno@chromium.org,
jkummerow@chromium.org, jochen@chromium.org
BUG=
==========

to

==========
s390x: implement vector support on s390

Add vfa/vfs/vfm/vfd support on s390

R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com, danno@chromium.org,
jkummerow@chromium.org, jochen@chromium.org
BUG=
==========

[john.yan, 2016-12-16 01:00:55]

jyan@ca.ibm.com changed reviewers:
+ joransiu@ca.ibm.com
- =joransiu@ca.ibm.com

[john.yan, 2016-12-16 01:09:01]

ptal

[JoranSiu, 2016-12-16 01:11:07]

https://codereview.chromium.org/2582683002/diff/1/src/s390/constants-s390.h
File src/s390/constants-s390.h (right):

https://codereview.chromium.org/2582683002/diff/1/src/s390/constants-s390.h#n...
src/s390/constants-s390.h:161: V(wfc, WFC, 0xE7CB)     /* Vector FP Op */ \
CAn we expand the comments to note the actual operation instead of a generic
"Vector FP Op"... saves us from the trouble of having to reference the
Principles of Operation.

https://codereview.chromium.org/2582683002/diff/1/src/s390/simulator-s390.cc
File src/s390/simulator-s390.cc (right):

https://codereview.chromium.org/2582683002/diff/1/src/s390/simulator-s390.cc#...
src/s390/simulator-s390.cc:6092: DCHECK_OPCODE(VFA);
Should this be VFS?

https://codereview.chromium.org/2582683002/diff/1/src/s390/simulator-s390.cc#...
src/s390/simulator-s390.cc:6107: DCHECK_OPCODE(VFA);
VFM?

https://codereview.chromium.org/2582683002/diff/1/src/s390/simulator-s390.cc#...
src/s390/simulator-s390.cc:6122: DCHECK_OPCODE(VFA);
VFD?

[JoranSiu, 2016-12-16 01:30:55]

lgtm

[Jakob Kummerow, 2016-12-16 02:04:53]

globals.h LGTM, haven't reviewed s390-specific changes.

[john.yan, 2016-12-16 03:21:42]

On 2016/12/16 02:04:53, Jakob Kummerow wrote:
> globals.h LGTM, haven't reviewed s390-specific changes.

Thanks!

[john.yan, 2016-12-16 03:21:47]

The CQ bit was checked by jyan@ca.ibm.com

[commit-bot: I haz the power, 2016-12-16 03:21:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 04:08:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481858507158810,
"parent_rev": "1c5e1504e0305363cd262f1706cbd63f9a62ae46", "commit_rev":
"efd92a1659a6aa1964d12cdda67946ce9b2f6461"}

[commit-bot: I haz the power, 2016-12-16 04:08:44]

Description was changed from

==========
s390x: implement vector support on s390

Add vfa/vfs/vfm/vfd support on s390

R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com, danno@chromium.org,
jkummerow@chromium.org, jochen@chromium.org
BUG=
==========

to

==========
s390x: implement vector support on s390

Add vfa/vfs/vfm/vfd support on s390

R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com, danno@chromium.org,
jkummerow@chromium.org, jochen@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2582683002
Cr-Commit-Position: refs/heads/master@{#41741}
Committed:
https://chromium.googlesource.com/v8/v8/+/efd92a1659a6aa1964d12cdda67946ce9b2...
==========

[commit-bot: I haz the power, 2016-12-16 04:08:45]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/efd92a1659a6aa1964d12cdda67946ce9b2...