Simplify AudioInputRendererHost IPC interface.

Simplify AudioInputRendererHost IPC interface.

Some unused messages and useless code removed.

BUG=180640
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2582533002
Cr-Commit-Position: refs/heads/master@{#442243}
Committed: https://chromium.googlesource.com/chromium/src/+/e4faf83271909053e53e988ffc274eb6ef6f7702

[Max Morin, 2016-12-15 15:02:45]

Description was changed from

==========
Simplify AudioInputRendererHost IPC interface.

Some unused messages and useless code removed.

BUG=180640
==========

to

==========
Simplify AudioInputRendererHost IPC interface.

Some unused messages and useless code removed.

BUG=180640
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Max Morin, 2016-12-15 15:03:31]

Description was changed from

==========
Simplify AudioInputRendererHost IPC interface.

Some unused messages and useless code removed.

BUG=180640
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Simplify AudioInputRendererHost IPC interface.

Some unused messages and useless code removed.

BUG=180640
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Max Morin, 2016-12-15 15:12:39]

maxmorin@chromium.org changed reviewers:
+ bbudge@chromium.org, dalecurtis@chromium.org

[Max Morin, 2016-12-15 15:12:40]

Dale: PTAL at this small cleanup when you're back in office.
Bbudge: PTAL at pepper changes.

https://codereview.chromium.org/2582533002/diff/1/media/audio/audio_input_dev...
File media/audio/audio_input_device.cc (left):

https://codereview.chromium.org/2582533002/diff/1/media/audio/audio_input_dev...
media/audio/audio_input_device.cc:173: case
AUDIO_INPUT_IPC_DELEGATE_STATE_STOPPED:
This message is handled here, but is never actually sent from the host.

[bbudge, 2016-12-15 15:17:29]

content/renderer/pepper lgtm

[DaleCurtis, 2016-12-20 17:38:12]

Nice cleanup, lgtm!

[Max Morin, 2017-01-09 09:04:53]

maxmorin@chromium.org changed reviewers:
+ tommi@chromium.org

[Max Morin, 2017-01-09 09:05:28]

Tommi: PTAL at content/browser/speech/speech_recognizer_impl.h

[tommi (sloooow) - chröme, 2017-01-09 09:25:19]

nice. lgtm.

https://codereview.chromium.org/2582533002/diff/40001/content/renderer/media/...
File content/renderer/media/audio_input_message_filter.cc (left):

https://codereview.chromium.org/2582533002/diff/40001/content/renderer/media/...
content/renderer/media/audio_input_message_filter.cc:168:
delegate->OnStateChanged(state);
I have another change in flight and I don't think we'll have conflicts, but just
fyi, here's the change:
https://codereview.chromium.org/2623443002/

https://codereview.chromium.org/2582533002/diff/40001/media/audio/audio_input...
File media/audio/audio_input_device.cc (right):

https://codereview.chromium.org/2582533002/diff/40001/media/audio/audio_input...
media/audio/audio_input_device.cc:158: void AudioInputDevice::OnError() {
Nice, OnError makes a lot more sense :)

[Max Morin, 2017-01-09 09:30:25]

The CQ bit was checked by maxmorin@chromium.org

[Max Morin, 2017-01-09 09:30:26]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2582533002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-01-09 09:30:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 09:36:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 09:36:39]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Max Morin, 2017-01-09 09:42:47]

maxmorin@chromium.org changed reviewers:
+ mkwst@chromium.org

[Max Morin, 2017-01-09 09:48:22]

Thanks Tommi.
Mike West: PTAL at content/common/media/audio_messages.h.

[Mike West, 2017-01-09 12:34:40]

IPC LGTM.

[Max Morin, 2017-01-09 13:13:03]

The CQ bit was checked by maxmorin@chromium.org

[commit-bot: I haz the power, 2017-01-09 13:13:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 13:18:01]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483967583035150,
"parent_rev": "1c7f20d3d858eb3381c003970a2d9179c2437a47", "commit_rev":
"e4faf83271909053e53e988ffc274eb6ef6f7702"}

[commit-bot: I haz the power, 2017-01-09 13:18:30]

Description was changed from

==========
Simplify AudioInputRendererHost IPC interface.

Some unused messages and useless code removed.

BUG=180640
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Simplify AudioInputRendererHost IPC interface.

Some unused messages and useless code removed.

BUG=180640
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2582533002
Cr-Commit-Position: refs/heads/master@{#442243}
Committed:
https://chromium.googlesource.com/chromium/src/+/e4faf83271909053e53e988ffc27...
==========

[commit-bot: I haz the power, 2017-01-09 13:18:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e4faf83271909053e53e988ffc27...