Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: content/browser/renderer_host/media/audio_input_renderer_host.cc

Issue 2582533002: Simplify AudioInputRendererHost IPC interface. (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_input_renderer_host.cc
diff --git a/content/browser/renderer_host/media/audio_input_renderer_host.cc b/content/browser/renderer_host/media/audio_input_renderer_host.cc
index 661924a6af911544f298605d7216555337909ce5..444761c33b9926ac6d67e27b9aad6ca1570e263d 100644
--- a/content/browser/renderer_host/media/audio_input_renderer_host.cc
+++ b/content/browser/renderer_host/media/audio_input_renderer_host.cc
@@ -148,14 +148,6 @@ void AudioInputRendererHost::OnCreated(
base::RetainedRef(controller)));
}
-void AudioInputRendererHost::OnRecording(
- media::AudioInputController* controller) {
- BrowserThread::PostTask(
- BrowserThread::IO, FROM_HERE,
- base::Bind(&AudioInputRendererHost::DoSendRecordingMessage, this,
- base::RetainedRef(controller)));
-}
-
void AudioInputRendererHost::OnError(media::AudioInputController* controller,
media::AudioInputController::ErrorCode error_code) {
BrowserThread::PostTask(
@@ -222,17 +214,6 @@ void AudioInputRendererHost::DoCompleteCreation(
entry->shared_memory_segment_count));
}
-void AudioInputRendererHost::DoSendRecordingMessage(
- media::AudioInputController* controller) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
- // TODO(henrika): See crbug.com/115262 for details on why this method
- // should be implemented.
- AudioEntry* entry = LookupByController(controller);
- DCHECK(entry) << "AudioInputController is invalid.";
- LogMessage(
- entry->stream_id, "DoSendRecordingMessage: stream is now started", true);
-}
-
void AudioInputRendererHost::DoHandleError(
media::AudioInputController* controller,
media::AudioInputController::ErrorCode error_code) {
@@ -499,8 +480,7 @@ void AudioInputRendererHost::SendErrorMessage(
base::StringPrintf("SendErrorMessage(error_code=%d)", error_code);
LogMessage(stream_id, err_msg, true);
- Send(new AudioInputMsg_NotifyStreamStateChanged(
- stream_id, media::AUDIO_INPUT_IPC_DELEGATE_STATE_ERROR));
+ Send(new AudioInputMsg_NotifyStreamError(stream_id));
}
void AudioInputRendererHost::DeleteEntries() {

Powered by Google App Engine
This is Rietveld 408576698