Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1282)

Unified Diff: content/renderer/media/audio_input_message_filter.cc

Issue 2582533002: Simplify AudioInputRendererHost IPC interface. (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_input_message_filter.cc
diff --git a/content/renderer/media/audio_input_message_filter.cc b/content/renderer/media/audio_input_message_filter.cc
index 1659af3c8dc0f139eedb70dd4fe4d7286fd3e66b..46b4e4c44194b1c5b6dbac06c9e7134466640968 100644
--- a/content/renderer/media/audio_input_message_filter.cc
+++ b/content/renderer/media/audio_input_message_filter.cc
@@ -4,6 +4,8 @@
#include "content/renderer/media/audio_input_message_filter.h"
+#include <string>
+
#include "base/bind.h"
#include "base/single_thread_task_runner.h"
#include "base/strings/stringprintf.h"
@@ -84,9 +86,7 @@ bool AudioInputMessageFilter::OnMessageReceived(const IPC::Message& message) {
IPC_BEGIN_MESSAGE_MAP(AudioInputMessageFilter, message)
IPC_MESSAGE_HANDLER(AudioInputMsg_NotifyStreamCreated,
OnStreamCreated)
- IPC_MESSAGE_HANDLER(AudioInputMsg_NotifyStreamVolume, OnStreamVolume)
- IPC_MESSAGE_HANDLER(AudioInputMsg_NotifyStreamStateChanged,
- OnStreamStateChanged)
+ IPC_MESSAGE_HANDLER(AudioInputMsg_NotifyStreamError, OnStreamError)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
return handled;
@@ -145,19 +145,7 @@ void AudioInputMessageFilter::OnStreamCreated(
delegate->OnStreamCreated(handle, socket_handle, length, total_segments);
}
-void AudioInputMessageFilter::OnStreamVolume(int stream_id, double volume) {
- DCHECK(io_task_runner_->BelongsToCurrentThread());
- media::AudioInputIPCDelegate* delegate = delegates_.Lookup(stream_id);
- if (!delegate) {
- DLOG(WARNING) << "Got audio stream event for a non-existent or removed"
- << " audio capturer.";
- return;
- }
- delegate->OnVolume(volume);
-}
-
-void AudioInputMessageFilter::OnStreamStateChanged(
- int stream_id, media::AudioInputIPCDelegateState state) {
+void AudioInputMessageFilter::OnStreamError(int stream_id) {
DCHECK(io_task_runner_->BelongsToCurrentThread());
media::AudioInputIPCDelegate* delegate = delegates_.Lookup(stream_id);
if (!delegate) {
@@ -165,7 +153,7 @@ void AudioInputMessageFilter::OnStreamStateChanged(
<< " audio renderer.";
return;
}
- delegate->OnStateChanged(state);
tommi (sloooow) - chröme 2017/01/09 09:25:19 I have another change in flight and I don't think
+ delegate->OnError();
}
AudioInputMessageFilter::AudioInputIPCImpl::AudioInputIPCImpl(

Powered by Google App Engine
This is Rietveld 408576698