Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 25825003: Move ANGLEWebKitBridge to platform/graphics/angle/ANGLEPlatformBridge. (Closed)

Created:
7 years, 2 months ago by Stephen Chennney
Modified:
7 years, 2 months ago
CC:
blink-reviews, jamesr, dsinclair, danakj, Rik, pdr.
Visibility:
Public.

Description

Move ANGLEWebKitBridge to platform/graphics/angle/ANGLEPlatformBridge. Part of the effort to migrate platform out of core. R=abarth@chromium.org, abarth, eae, senorblanco BUG=303332 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158988

Patch Set 1 #

Total comments: 2

Patch Set 2 : Tested update, rebased. Ready to commit. #

Patch Set 3 : Rebased to commit. #

Patch Set 4 : Fixed bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -355 lines) Patch
M Source/core/core.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D Source/core/platform/graphics/ANGLEWebKitBridge.h View 1 chunk +0 lines, -96 lines 0 comments Download
D Source/core/platform/graphics/ANGLEWebKitBridge.cpp View 1 chunk +0 lines, -227 lines 0 comments Download
M Source/core/platform/graphics/filters/custom/CustomFilterGlobalContext.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/platform/graphics/filters/custom/CustomFilterGlobalContext.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/platform/graphics/filters/custom/CustomFilterValidatedProgram.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/blink_platform.gyp View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A + Source/platform/graphics/angle/ANGLEPlatformBridge.h View 1 2 chunks +11 lines, -10 lines 0 comments Download
A + Source/platform/graphics/angle/ANGLEPlatformBridge.cpp View 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Stephen Chennney
Not sure if this is right. Local build is broken for some reason seemingly unrelated.
7 years, 2 months ago (2013-10-03 02:00:44 UTC) #1
jamesr
Why do we even have this? All interactions with ANGLE for WebGL should be outside ...
7 years, 2 months ago (2013-10-03 02:12:20 UTC) #2
abarth-chromium
Maybe this is for CSS shaders? It would be good to understand.
7 years, 2 months ago (2013-10-03 03:26:35 UTC) #3
Stephen Chennney
On 2013/10/03 03:26:35, abarth wrote: > Maybe this is for CSS shaders? It would be ...
7 years, 2 months ago (2013-10-03 14:23:44 UTC) #4
abarth-chromium
LGTM https://codereview.chromium.org/25825003/diff/1/Source/platform/blink_platform.gyp File Source/platform/blink_platform.gyp (right): https://codereview.chromium.org/25825003/diff/1/Source/platform/blink_platform.gyp#newcode67 Source/platform/blink_platform.gyp:67: '<(DEPTH)/third_party/angle_dx11/src/build_angle.gyp:translator_glsl', Can you add comments about what these ...
7 years, 2 months ago (2013-10-03 16:45:01 UTC) #5
jamesr
I think zmo just fixed some translator_glsl dependencies. Check these with him before landing. To ...
7 years, 2 months ago (2013-10-03 17:11:30 UTC) #6
Zhenyao Mo
On 2013/10/03 17:11:30, jamesr wrote: > I think zmo just fixed some translator_glsl dependencies. Check ...
7 years, 2 months ago (2013-10-03 17:44:01 UTC) #7
Stephen Chennney
On 2013/10/03 17:44:01, Zhenyao Mo wrote: > On 2013/10/03 17:11:30, jamesr wrote: > > I ...
7 years, 2 months ago (2013-10-03 19:32:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/25825003/11001
7 years, 2 months ago (2013-10-03 19:32:54 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=6705
7 years, 2 months ago (2013-10-03 22:13:12 UTC) #10
Stephen Chennney
7 years, 2 months ago (2013-10-05 13:48:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 manually as r158988 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698