Issue 258243003: Remove old-style accessor support from runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 258243003: Remove old-style accessor support from runtime. (Closed)

Created:
6 years, 7 months ago by ulan

Modified:
6 years, 7 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove old-style accessor support from runtime. BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21041

Patch Set 2 : Address comment #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -138 lines)			Patch
M	src/accessors.h	View		4 chunks	+7 lines, -30 lines	0 comments	Download
M	src/accessors.cc	View		2 chunks	+6 lines, -33 lines	0 comments	Download
M	src/ic.cc	View	1	2 chunks	+2 lines, -17 lines	0 comments	Download
M	src/objects.cc	View		4 chunks	+2 lines, -35 lines	0 comments	Download
M	src/property.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/runtime.cc	View		3 chunks	+5 lines, -2 lines	0 comments	Download
M	src/serialize.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	test/cctest/test-alloc.cc	View		3 chunks	+25 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with nits. https://codereview.chromium.org/258243003/diff/1/src/ic.cc File src/ic.cc (right): https://codereview.chromium.org/258243003/diff/1/src/ic.cc#newcode1035 src/ic.cc:1035: UNREACHABLE(); We could also just ASSERT(callback->IsDeclaredAccessorInfo()) ...

6 years, 7 months ago (2014-04-29 10:43:11 UTC) #2

ulan

6 years, 7 months ago (2014-04-29 10:59:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21041 (presubmit successful).

Expand Messages | Collapse Messages

Issue 258243003: Remove old-style accessor support from runtime. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment #

Messages