Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/serialize.cc

Issue 258243003: Remove old-style accessor support from runtime. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comment Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/runtime.cc ('k') | test/cctest/test-alloc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 NULL 262 NULL
263 #undef BUILD_NAME_LITERAL 263 #undef BUILD_NAME_LITERAL
264 }; 264 };
265 265
266 for (uint16_t i = 0; i < Isolate::kIsolateAddressCount; ++i) { 266 for (uint16_t i = 0; i < Isolate::kIsolateAddressCount; ++i) {
267 Add(isolate->get_address_from_id((Isolate::AddressId)i), 267 Add(isolate->get_address_from_id((Isolate::AddressId)i),
268 TOP_ADDRESS, i, AddressNames[i]); 268 TOP_ADDRESS, i, AddressNames[i]);
269 } 269 }
270 270
271 // Accessors 271 // Accessors
272 #define ACCESSOR_DESCRIPTOR_DECLARATION(name) \
273 Add((Address)&Accessors::name, \
274 ACCESSOR, \
275 Accessors::k##name, \
276 "Accessors::" #name);
277 ACCESSOR_DESCRIPTOR_LIST(ACCESSOR_DESCRIPTOR_DECLARATION)
278 #undef ACCESSOR_DESCRIPTOR_DECLARATION
279
280 #define ACCESSOR_INFO_DECLARATION(name) \ 272 #define ACCESSOR_INFO_DECLARATION(name) \
281 Add(FUNCTION_ADDR(&Accessors::name##Getter), \ 273 Add(FUNCTION_ADDR(&Accessors::name##Getter), \
282 ACCESSOR, \ 274 ACCESSOR, \
283 Accessors::k##name##Getter, \ 275 Accessors::k##name##Getter, \
284 "Accessors::" #name "Getter"); \ 276 "Accessors::" #name "Getter"); \
285 Add(FUNCTION_ADDR(&Accessors::name##Setter), \ 277 Add(FUNCTION_ADDR(&Accessors::name##Setter), \
286 ACCESSOR, \ 278 ACCESSOR, \
287 Accessors::k##name##Setter, \ 279 Accessors::k##name##Setter, \
288 "Accessors::" #name "Setter"); 280 "Accessors::" #name "Setter");
289 ACCESSOR_INFO_LIST(ACCESSOR_INFO_DECLARATION) 281 ACCESSOR_INFO_LIST(ACCESSOR_INFO_DECLARATION)
(...skipping 1614 matching lines...) Expand 10 before | Expand all | Expand 10 after
1904 1896
1905 bool SnapshotByteSource::AtEOF() { 1897 bool SnapshotByteSource::AtEOF() {
1906 if (0u + length_ - position_ > 2 * sizeof(uint32_t)) return false; 1898 if (0u + length_ - position_ > 2 * sizeof(uint32_t)) return false;
1907 for (int x = position_; x < length_; x++) { 1899 for (int x = position_; x < length_; x++) {
1908 if (data_[x] != SerializerDeserializer::nop()) return false; 1900 if (data_[x] != SerializerDeserializer::nop()) return false;
1909 } 1901 }
1910 return true; 1902 return true;
1911 } 1903 }
1912 1904
1913 } } // namespace v8::internal 1905 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/runtime.cc ('k') | test/cctest/test-alloc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698