Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: src/property.h

Issue 258243003: Remove old-style accessor support from runtime. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comment Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_PROPERTY_H_ 5 #ifndef V8_PROPERTY_H_
6 #define V8_PROPERTY_H_ 6 #define V8_PROPERTY_H_
7 7
8 #include "isolate.h" 8 #include "isolate.h"
9 #include "factory.h" 9 #include "factory.h"
10 #include "types.h" 10 #include "types.h"
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
338 338
339 case DESCRIPTOR_TYPE: 339 case DESCRIPTOR_TYPE:
340 case DICTIONARY_TYPE: 340 case DICTIONARY_TYPE:
341 switch (type()) { 341 switch (type()) {
342 case FIELD: 342 case FIELD:
343 case NORMAL: 343 case NORMAL:
344 case CONSTANT: 344 case CONSTANT:
345 return true; 345 return true;
346 case CALLBACKS: { 346 case CALLBACKS: {
347 Object* callback = GetCallbackObject(); 347 Object* callback = GetCallbackObject();
348 return callback->IsAccessorInfo() || callback->IsForeign(); 348 ASSERT(!callback->IsForeign());
349 return callback->IsAccessorInfo();
349 } 350 }
350 case HANDLER: 351 case HANDLER:
351 case INTERCEPTOR: 352 case INTERCEPTOR:
352 case NONEXISTENT: 353 case NONEXISTENT:
353 UNREACHABLE(); 354 UNREACHABLE();
354 return false; 355 return false;
355 } 356 }
356 } 357 }
357 UNREACHABLE(); 358 UNREACHABLE();
358 return false; 359 return false;
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
530 JSReceiver* holder_; 531 JSReceiver* holder_;
531 Map* transition_; 532 Map* transition_;
532 int number_; 533 int number_;
533 bool cacheable_; 534 bool cacheable_;
534 PropertyDetails details_; 535 PropertyDetails details_;
535 }; 536 };
536 537
537 } } // namespace v8::internal 538 } } // namespace v8::internal
538 539
539 #endif // V8_PROPERTY_H_ 540 #endif // V8_PROPERTY_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698