Remove old-style accessor support from runtime.

src/ic.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1014 matching lines @@
         CallOptimization call_optimization(function);
         if (call_optimization.is_simple_api_call() &&
             call_optimization.IsCompatibleReceiver(object, holder)) {
           return compiler.CompileLoadCallback(
               type, holder, name, call_optimization);
         }
         return compiler.CompileLoadViaGetter(type, holder, name, function);
       }
       // TODO(dcarney): Handle correctly.
       if (callback->IsDeclaredAccessorInfo()) break;
-      ASSERT(callback->IsForeign());
-      // No IC support for old-style native accessors.
+      UNREACHABLE();

[Yang, 2014/04/29 10:43:12]

We could also just ASSERT(callback->IsDeclaredAccessorInfo())

       break;
     }
     case INTERCEPTOR:
       ASSERT(HasInterceptorGetter(*holder));
       return compiler.CompileLoadInterceptor(type, holder, name);
     default:
       break;
   }
 
   return slow_stub();
@@ skipping 403 matching lines @@
           if (call_optimization.is_simple_api_call() &&
               call_optimization.IsCompatibleReceiver(receiver, holder)) {
             return compiler.CompileStoreCallback(
                 receiver, holder, name, call_optimization);
           }
           return compiler.CompileStoreViaSetter(
               receiver, holder, name, Handle<JSFunction>::cast(setter));
         }
         // TODO(dcarney): Handle correctly.
         if (callback->IsDeclaredAccessorInfo()) break;
-        ASSERT(callback->IsForeign());
-
-        // Use specialized code for setting the length of arrays with fast
-        // properties. Slow properties might indicate redefinition of the length
-        // property.
-        if (receiver->IsJSArray() &&
-            String::Equals(isolate()->factory()->length_string(), name) &&
-            Handle<JSArray>::cast(receiver)->AllowsSetElementsLength() &&
-            receiver->HasFastProperties()) {
-          return compiler.CompileStoreArrayLength(receiver, lookup, name);
-        }
-
-        // No IC support for old-style native accessors.
+        UNREACHABLE();

[Yang, 2014/04/29 10:43:12]

Ditto.

         break;
       }
       case INTERCEPTOR:
         if (kind() == Code::KEYED_STORE_IC) break;
         ASSERT(HasInterceptorSetter(*holder));
         return compiler.CompileStoreInterceptor(receiver, name);
       case CONSTANT:
         break;
       case NONEXISTENT:
       case HANDLER:
@@ skipping 1464 matching lines @@
 #undef ADDR
 };
 
 
 Address IC::AddressFromUtilityId(IC::UtilityId id) {
   return IC_utilities[id];
 }
 
 
 } }  // namespace v8::internal