Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2582253002: logdog: Use gRPC credentials when creating PubSub client, not http.Client. (Closed)

Created:
4 years ago by Vadim Sh.
Modified:
4 years ago
Reviewers:
dnj
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

logdog: Use gRPC credentials when creating PubSub client, not http.Client. http.Client is not supported by PubSub lib anymore. R=dnj@chromium.org BUG=675401 Review-Url: https://codereview.chromium.org/2582253002 Committed: https://github.com/luci/luci-go/commit/9d5021772cca20e36f0792434a790f4fb851ca03

Patch Set 1 #

Patch Set 2 : oops, actually pass the client #

Patch Set 3 : clear gRPC metadata as a precation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
M logdog/appengine/coordinator/archivalPublisher.go View 3 chunks +10 lines, -0 lines 0 comments Download
M logdog/appengine/coordinator/coordinatorTest/archival.go View 2 chunks +18 lines, -0 lines 0 comments Download
M logdog/appengine/coordinator/mutations/createArchiveTask.go View 1 chunk +5 lines, -0 lines 0 comments Download
M logdog/appengine/coordinator/service.go View 1 2 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Vadim Sh.
4 years ago (2016-12-18 01:39:00 UTC) #1
dnj
lgtm
4 years ago (2016-12-18 15:52:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582253002/40001
4 years ago (2016-12-18 15:52:06 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-18 15:57:47 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/9d5021772cca20e36f0792434a790f4fb851ca03

Powered by Google App Engine
This is Rietveld 408576698