Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: logdog/appengine/coordinator/mutations/createArchiveTask.go

Issue 2582253002: logdog: Use gRPC credentials when creating PubSub client, not http.Client. (Closed)
Patch Set: clear gRPC metadata as a precation Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « logdog/appengine/coordinator/coordinatorTest/archival.go ('k') | logdog/appengine/coordinator/service.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/appengine/coordinator/mutations/createArchiveTask.go
diff --git a/logdog/appengine/coordinator/mutations/createArchiveTask.go b/logdog/appengine/coordinator/mutations/createArchiveTask.go
index 16220227ee14d3f03a771f53100d7df359c9ba07..5e0530cec2d97d255bd541b502da21f1989bd09d 100644
--- a/logdog/appengine/coordinator/mutations/createArchiveTask.go
+++ b/logdog/appengine/coordinator/mutations/createArchiveTask.go
@@ -47,6 +47,11 @@ func (m *CreateArchiveTask) RollForward(c context.Context) ([]tumble.Mutation, e
log.WithError(err).Errorf(c, "Failed to get archival publisher.")
return nil, err
}
+ defer func() {
+ if err := ap.Close(); err != nil {
+ log.WithError(err).Warningf(c, "Failed to close archival publisher.")
+ }
+ }()
// Get the log stream.
state := m.logStream().State(c)
« no previous file with comments | « logdog/appengine/coordinator/coordinatorTest/archival.go ('k') | logdog/appengine/coordinator/service.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698