Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Unified Diff: logdog/appengine/coordinator/coordinatorTest/archival.go

Issue 2582253002: logdog: Use gRPC credentials when creating PubSub client, not http.Client. (Closed)
Patch Set: clear gRPC metadata as a precation Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: logdog/appengine/coordinator/coordinatorTest/archival.go
diff --git a/logdog/appengine/coordinator/coordinatorTest/archival.go b/logdog/appengine/coordinator/coordinatorTest/archival.go
index 1dfa74b69ec3981569004e183b3bd13c9cb6f9dc..a73742a8809568d01d5356296f0ce457e665fa03 100644
--- a/logdog/appengine/coordinator/coordinatorTest/archival.go
+++ b/logdog/appengine/coordinator/coordinatorTest/archival.go
@@ -5,6 +5,7 @@
package coordinatorTest
import (
+ "fmt"
"sort"
"sync"
@@ -22,17 +23,34 @@ type ArchivalPublisher struct {
// Err, if not nil, is the error returned by Publish.
Err error
+ closed bool
tasks []*logdog.ArchiveTask
archivalIndex uint64
}
var _ coordinator.ArchivalPublisher = (*ArchivalPublisher)(nil)
+func (ap *ArchivalPublisher) Close() error {
+ ap.Lock()
+ defer ap.Unlock()
+
+ if ap.closed {
+ return fmt.Errorf("already closed")
+ }
+ ap.closed = true
+
+ return nil
+}
+
// Publish implements coordinator.ArchivalPublisher.
func (ap *ArchivalPublisher) Publish(c context.Context, at *logdog.ArchiveTask) error {
ap.Lock()
defer ap.Unlock()
+ if ap.closed {
+ return fmt.Errorf("closed")
+ }
+
if err := ap.Err; err != nil {
return err
}
« no previous file with comments | « logdog/appengine/coordinator/archivalPublisher.go ('k') | logdog/appengine/coordinator/mutations/createArchiveTask.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698