build/config/win/BUILD.gn - Issue 2581893002: Use the /WX flag to have link warnings treated as errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/win/BUILD.gn

Issue 2581893002: Use the /WX flag to have link warnings treated as errors. (Closed)

Patch Set: Move /WX setter into :compiler and respect fatal_linker_warnings Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/win/BUILD.gn

diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn

index 3da27470120c5fe17c564f6f012dff4694cbc627..b1cb7246fbf5d0e02d4ec2b313fab6f1ec19ad1e 100644

--- a/build/config/win/BUILD.gn

+++ b/build/config/win/BUILD.gn

@@ -238,17 +238,13 @@ config("sdk_link") {

# their own.

config("common_linker_setup") {

ldflags = [

+ "/fastfail",

"/FIXED:NO",

"/ignore:4199",

"/ignore:4221",

"/NXCOMPAT",

]

- ldflags += [

- # Tell the linker to crash on failures.

- "/fastfail",

- ]

# ASLR makes debugging with windbg difficult because Chrome.exe and

# Chrome.dll share the same base name. As result, windbg will name the

# Chrome.dll module like chrome_<base address>, where <base address>

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | media/BUILD.gn » ('j') | no next file with comments »