media/BUILD.gn - Issue 2581893002: Use the /WX flag to have link warnings treated as errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/BUILD.gn

Issue 2581893002: Use the /WX flag to have link warnings treated as errors. (Closed)

Patch Set: Move /WX setter into :compiler and respect fatal_linker_warnings Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/BUILD.gn

diff --git a/media/BUILD.gn b/media/BUILD.gn

index 279eab9bd6e88635fb965707e1c7d4a31057f503..c886c3961c4fa3fdbe778c22de35c2769edc8918 100644

--- a/media/BUILD.gn

+++ b/media/BUILD.gn

@@ -736,6 +736,14 @@ source_set("unit_tests") {

# Contains tests for all targets in the "media" folder.

# TODO(xhwang): Move mojo/capture/remoting tests here where applicable.

test("media_unittests") {

+ # crbug.com/676418: Suppress symbol import warnings.

+ if (is_win && is_component_build) {

+ ldflags = [

+ "/ignore:4217",

+ "/ignore:4049",

+ ]

+ }

deps = [

":unit_tests",

"//media/audio:unit_tests",

« no previous file with comments | « build/config/win/BUILD.gn ('k') | media/mojo/BUILD.gn » ('j') | no next file with comments »