Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3917)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2581893002: Use the /WX flag to have link warnings treated as errors. (Closed)
Patch Set: Move /WX setter into :compiler and respect fatal_linker_warnings Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/win/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index b5231b1537587a51bdcf520f1adb0afc7eb91cda..872641b7fe5bc5da18fcf9053575538146fea3cb 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -833,11 +833,15 @@ config("runtime_library") {
config("default_warnings") {
cflags = []
cflags_cc = []
+ ldflags = []
if (is_win) {
if (treat_warnings_as_errors) {
cflags += [ "/WX" ]
}
+ if (fatal_linker_warnings) {
+ ldflags += [ "/WX" ]
+ }
cflags += [
# Assume UTF-8 by default to avoid code page dependencies.
« no previous file with comments | « no previous file | build/config/win/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698