Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Side by Side Diff: build/config/win/BUILD.gn

Issue 2581893002: Use the /WX flag to have link warnings treated as errors. (Closed)
Patch Set: Move /WX setter into :compiler and respect fatal_linker_warnings Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | media/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/clang/clang.gni") 5 import("//build/config/clang/clang.gni")
6 import("//build/config/compiler/compiler.gni") 6 import("//build/config/compiler/compiler.gni")
7 import("//build/config/sanitizers/sanitizers.gni") 7 import("//build/config/sanitizers/sanitizers.gni")
8 import("//build/config/win/visual_studio_version.gni") 8 import("//build/config/win/visual_studio_version.gni")
9 import("//build/toolchain/toolchain.gni") 9 import("//build/toolchain/toolchain.gni")
10 10
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 "$visual_studio_path\VC\atlmfc\lib", 231 "$visual_studio_path\VC\atlmfc\lib",
232 ] 232 ]
233 } 233 }
234 } 234 }
235 235
236 # This default linker setup is provided separately from the SDK setup so 236 # This default linker setup is provided separately from the SDK setup so
237 # targets who want different library configurations can remove this and specify 237 # targets who want different library configurations can remove this and specify
238 # their own. 238 # their own.
239 config("common_linker_setup") { 239 config("common_linker_setup") {
240 ldflags = [ 240 ldflags = [
241 "/fastfail",
241 "/FIXED:NO", 242 "/FIXED:NO",
242 "/ignore:4199", 243 "/ignore:4199",
243 "/ignore:4221", 244 "/ignore:4221",
244 "/NXCOMPAT", 245 "/NXCOMPAT",
245 ] 246 ]
246 247
247 ldflags += [
248 # Tell the linker to crash on failures.
249 "/fastfail",
250 ]
251
252 # ASLR makes debugging with windbg difficult because Chrome.exe and 248 # ASLR makes debugging with windbg difficult because Chrome.exe and
253 # Chrome.dll share the same base name. As result, windbg will name the 249 # Chrome.dll share the same base name. As result, windbg will name the
254 # Chrome.dll module like chrome_<base address>, where <base address> 250 # Chrome.dll module like chrome_<base address>, where <base address>
255 # typically changes with each launch. This in turn means that breakpoints in 251 # typically changes with each launch. This in turn means that breakpoints in
256 # Chrome.dll don't stick from one launch to the next. For this reason, we 252 # Chrome.dll don't stick from one launch to the next. For this reason, we
257 # turn ASLR off in debug builds. 253 # turn ASLR off in debug builds.
258 if (is_debug) { 254 if (is_debug) {
259 ldflags += [ "/DYNAMICBASE:NO" ] 255 ldflags += [ "/DYNAMICBASE:NO" ]
260 } else { 256 } else {
261 ldflags += [ "/DYNAMICBASE" ] 257 ldflags += [ "/DYNAMICBASE" ]
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
423 419
424 # Internal stuff -------------------------------------------------------------- 420 # Internal stuff --------------------------------------------------------------
425 421
426 # Config used by the MIDL template to disable warnings. 422 # Config used by the MIDL template to disable warnings.
427 config("midl_warnings") { 423 config("midl_warnings") {
428 if (is_clang) { 424 if (is_clang) {
429 # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_". 425 # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_".
430 cflags = [ "-Wno-extra-tokens" ] 426 cflags = [ "-Wno-extra-tokens" ]
431 } 427 }
432 } 428 }
OLDNEW
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | media/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698