Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2581623002: Clarify the strings in the external protocol dialog. (Closed)

Created:
4 years ago by dominickn
Modified:
4 years ago
Reviewers:
msw
CC:
chromium-reviews, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify the strings in the external protocol dialog. Currently, clicking "Cancel" in an external protocol dialog with the "Always open links for <app>" option checked will permanently silence all protocol requests for that scheme. This result is unexpected given the strings. This CL updates the strings to clarify the behaviour. This is a stopgap fix for M56; future milestones will see further changes to the behaviour of this dialog to improve its usability. BUG=671658 Committed: https://crrev.com/eb32611eaf94923d6cfb2d0965603c63de4c4178 Cr-Commit-Position: refs/heads/master@{#439001}

Patch Set 1 #

Patch Set 2 : Update strings cf. UX #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/external_protocol_dialog.mm View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/external_protocol_dialog_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
dominickn
msw: PTAL, thanks! This is another small CL for the external protocol handler that will ...
4 years ago (2016-12-15 05:10:48 UTC) #5
msw
lgtm
4 years ago (2016-12-15 16:23:25 UTC) #8
dominickn
Thanks! FYI: ps2 has a minor string update from UX (adding "links" to the end ...
4 years ago (2016-12-15 23:09:20 UTC) #11
msw
still lgtm
4 years ago (2016-12-15 23:15:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581623002/20001
4 years ago (2016-12-16 01:46:33 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 03:34:44 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-16 03:37:34 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb32611eaf94923d6cfb2d0965603c63de4c4178
Cr-Commit-Position: refs/heads/master@{#439001}

Powered by Google App Engine
This is Rietveld 408576698