Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Side by Side Diff: chrome/browser/ui/external_protocol_dialog_delegate.cc

Issue 2581623002: Clarify the strings in the external protocol dialog. (Closed)
Patch Set: Update strings cf. UX Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/external_protocol_dialog.mm ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/external_protocol_dialog_delegate.h" 5 #include "chrome/browser/ui/external_protocol_dialog_delegate.h"
6 6
7 #include "chrome/browser/external_protocol/external_protocol_handler.h" 7 #include "chrome/browser/external_protocol/external_protocol_handler.h"
8 #include "chrome/grit/chromium_strings.h" 8 #include "chrome/grit/chromium_strings.h"
9 #include "chrome/grit/generated_resources.h" 9 #include "chrome/grit/generated_resources.h"
10 #include "components/strings/grit/components_strings.h" 10 #include "components/strings/grit/components_strings.h"
(...skipping 23 matching lines...) Expand all
34 34
35 ExternalProtocolDialogDelegate::~ExternalProtocolDialogDelegate() { 35 ExternalProtocolDialogDelegate::~ExternalProtocolDialogDelegate() {
36 } 36 }
37 37
38 base::string16 ExternalProtocolDialogDelegate::GetDialogButtonLabel( 38 base::string16 ExternalProtocolDialogDelegate::GetDialogButtonLabel(
39 ui::DialogButton button) const { 39 ui::DialogButton button) const {
40 if (button == ui::DIALOG_BUTTON_OK) { 40 if (button == ui::DIALOG_BUTTON_OK) {
41 return l10n_util::GetStringFUTF16(IDS_EXTERNAL_PROTOCOL_OK_BUTTON_TEXT, 41 return l10n_util::GetStringFUTF16(IDS_EXTERNAL_PROTOCOL_OK_BUTTON_TEXT,
42 ElideCommandName(program_name_)); 42 ElideCommandName(program_name_));
43 } 43 }
44 return l10n_util::GetStringUTF16(IDS_CANCEL); 44 return l10n_util::GetStringUTF16(IDS_EXTERNAL_PROTOCOL_CANCEL_BUTTON_TEXT);
45 } 45 }
46 46
47 base::string16 ExternalProtocolDialogDelegate::GetMessageText() const { 47 base::string16 ExternalProtocolDialogDelegate::GetMessageText() const {
48 return base::string16(); 48 return base::string16();
49 } 49 }
50 50
51 base::string16 ExternalProtocolDialogDelegate::GetCheckboxText() const { 51 base::string16 ExternalProtocolDialogDelegate::GetCheckboxText() const {
52 return l10n_util::GetStringFUTF16(IDS_EXTERNAL_PROTOCOL_CHECKBOX_TEXT, 52 return l10n_util::GetStringFUTF16(IDS_EXTERNAL_PROTOCOL_CHECKBOX_TEXT,
53 ElideCommandName(program_name_)); 53 ElideCommandName(program_name_));
54 } 54 }
(...skipping 14 matching lines...) Expand all
69 url, render_process_host_id_, tab_contents_id_); 69 url, render_process_host_id_, tab_contents_id_);
70 } 70 }
71 71
72 void ExternalProtocolDialogDelegate::DoCancel(const GURL& url, 72 void ExternalProtocolDialogDelegate::DoCancel(const GURL& url,
73 bool dont_block) const { 73 bool dont_block) const {
74 if (dont_block) { 74 if (dont_block) {
75 ExternalProtocolHandler::SetBlockState(url.scheme(), 75 ExternalProtocolHandler::SetBlockState(url.scheme(),
76 ExternalProtocolHandler::BLOCK); 76 ExternalProtocolHandler::BLOCK);
77 } 77 }
78 } 78 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/external_protocol_dialog.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698