chrome/browser/ui/cocoa/external_protocol_dialog.mm - Issue 2581623002: Clarify the strings in the external protocol dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/external_protocol_dialog.mm

Issue 2581623002: Clarify the strings in the external protocol dialog. (Closed)

Patch Set: Update strings cf. UX Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/external_protocol_dialog.mm

diff --git a/chrome/browser/ui/cocoa/external_protocol_dialog.mm b/chrome/browser/ui/cocoa/external_protocol_dialog.mm

index 48d087f3ded85dfaee9face0654d30e7bf54d73d..baafbbebe2fed1cd518e84f6c78db5c5a4ecb9b9 100644

--- a/chrome/browser/ui/cocoa/external_protocol_dialog.mm

+++ b/chrome/browser/ui/cocoa/external_protocol_dialog.mm

@@ -66,7 +66,9 @@ void ExternalProtocolHandler::RunExternalProtocolDialog(

addButtonWithTitle:l10n_util::GetNSStringFWithFixup(

IDS_EXTERNAL_PROTOCOL_OK_BUTTON_TEXT, appName)];

[allowButton setKeyEquivalent:@""]; // disallow as default

- [alert_ addButtonWithTitle:l10n_util::GetNSStringWithFixup(IDS_CANCEL)];

+ [alert_ addButtonWithTitle:

+ l10n_util::GetNSStringWithFixup(

+ IDS_EXTERNAL_PROTOCOL_CANCEL_BUTTON_TEXT)];

[alert_ setShowsSuppressionButton:YES];

[[alert_ suppressionButton]