chrome/browser/ui/autofill/popup_constants.h - Issue 2581513002: Replace hard-coded colors from ui::NativeTheme for consistency and accessibility.

Unified Diff: chrome/browser/ui/autofill/popup_constants.h

Issue 2581513002: Replace hard-coded colors from ui::NativeTheme for consistency and accessibility. (Closed)

Patch Set: Delete unused popup_constants.h includes Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/popup_constants.h

diff --git a/chrome/browser/ui/autofill/popup_constants.h b/chrome/browser/ui/autofill/popup_constants.h

index 30c1dfc7759425d8dfab5dd478a48e409ba69ded..f60f14bbaef16b1df0fc9881f88769fcf877135d 100644

--- a/chrome/browser/ui/autofill/popup_constants.h

+++ b/chrome/browser/ui/autofill/popup_constants.h

@@ -5,22 +5,11 @@

#ifndef CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_

#define CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_

-#include "third_party/skia/include/core/SkColor.h"

namespace autofill {

// The size of the border around the entire results popup, in pixels.

Evan Stade 2016/12/20 18:01:19 looks like this is actually in dip, not pixels, i.

jiahuiguo 2017/01/03 19:37:52 Changed the doc and filed a bug for changing to 1p

Mathieu 2017/01/04 13:51:48 Can you reference the bug here like so: TODO(crbu

jiahuiguo 2017/01/05 19:21:20 Done.

const int kPopupBorderThickness = 1;

-// Various colors used in the Autofill popup.

-// TODO(crbug.com/666523): These colors ought to be replaced by getting colors

-// from ui::NativeTheme for consistency and accessibility.

-const SkColor kBorderColor = SkColorSetRGB(0xC7, 0xCA, 0xCE);

-const SkColor kHoveredBackgroundColor = SkColorSetRGB(0xCD, 0xCD, 0xCD);

-const SkColor kLabelTextColor = SkColorSetRGB(0x64, 0x64, 0x64);

-constexpr SkColor kPopupBackground = SK_ColorWHITE;

-constexpr SkColor kValueTextColor = SK_ColorBLACK;

} // namespace autofill

#endif // CHROME_BROWSER_UI_AUTOFILL_POPUP_CONSTANTS_H_