Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3867)

Unified Diff: chrome/browser/ui/views/autofill/autofill_popup_base_view.cc

Issue 2581513002: Replace hard-coded colors from ui::NativeTheme for consistency and accessibility. (Closed)
Patch Set: Delete unused popup_constants.h includes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/autofill/autofill_popup_base_view.cc
diff --git a/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc b/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc
index dd09b9ac9d72753e8e32a00039d4380b781d8446..34d1bf15c86c9d7235b100fdff84fa2a5ec4b8fc 100644
--- a/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc
+++ b/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc
@@ -10,6 +10,7 @@
#include "base/threading/thread_task_runner_handle.h"
#include "build/build_config.h"
#include "chrome/browser/ui/autofill/popup_constants.h"
+#include "ui/native_theme/native_theme.h"
#include "ui/views/border.h"
#include "ui/views/focus/focus_manager.h"
#include "ui/views/widget/widget.h"
@@ -60,7 +61,10 @@ void AutofillPopupBaseView::DoShow() {
show_time_ = base::Time::Now();
}
- SetBorder(views::CreateSolidBorder(kPopupBorderThickness, kBorderColor));
+ SetBorder(views::CreateSolidBorder(
+ kPopupBorderThickness,
+ GetNativeTheme()->GetSystemColor(
+ ui::NativeTheme::kColorId_UnfocusedBorderColor)));
Mathieu 2016/12/20 20:36:40 Is there a possibility to have a code path where w
jiahuiguo 2017/01/03 19:37:52 Done. Added in https://crbug.com/676164
Mathieu 2017/01/04 13:51:48 Please reference here: // TODO(crbug.com/676164):
jiahuiguo 2017/01/05 19:21:20 Done.
DoUpdateBoundsAndRedrawPopup();
GetWidget()->Show();

Powered by Google App Engine
This is Rietveld 408576698