Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 2581473002: DCHECK for a valid error callback callback in GetIsPinnedToTaskbarState (Closed)

Created:
4 years ago by Patrick Monette
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DCHECK for a valid error callback in GetIsPinnedToTaskbarState Fixes a crash that could happens when closing the Win10 welcome page while the utility process is running. BUG= Committed: https://crrev.com/83edc1eaf8af9d1e069fbf9551d809b29aaf85cf Cr-Commit-Position: refs/heads/master@{#438864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/shell_integration_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/welcome_win10_handler.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Patrick Monette
grt@ PTAL at shell_integration_win michaelpg@ PTAL at cr/b/ui Thanks!
4 years ago (2016-12-14 23:16:18 UTC) #4
michaelpg
lgtm
4 years ago (2016-12-15 01:51:06 UTC) #5
grt (UTC plus 2)
lgtm
4 years ago (2016-12-15 09:11:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581473002/1
4 years ago (2016-12-15 16:46:03 UTC) #8
Patrick Monette
Thanks!
4 years ago (2016-12-15 16:50:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 17:37:20 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-15 17:38:57 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83edc1eaf8af9d1e069fbf9551d809b29aaf85cf
Cr-Commit-Position: refs/heads/master@{#438864}

Powered by Google App Engine
This is Rietveld 408576698