Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/browser/shell_integration_win.cc

Issue 2581473002: DCHECK for a valid error callback callback in GetIsPinnedToTaskbarState (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/welcome_win10_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/shell_integration_win.cc
diff --git a/chrome/browser/shell_integration_win.cc b/chrome/browser/shell_integration_win.cc
index fffcc9c46b1552a94d946b33cc37cec1c9a93233..dc45ad026f0f9ffe6dd02c96325dac25e8be7212 100644
--- a/chrome/browser/shell_integration_win.cc
+++ b/chrome/browser/shell_integration_win.cc
@@ -487,6 +487,9 @@ IsPinnedToTaskbarHelper::IsPinnedToTaskbarHelper(
l10n_util::GetStringUTF16(IDS_UTILITY_PROCESS_SHELL_HANDLER_NAME)),
error_callback_(error_callback),
result_callback_(result_callback) {
+ DCHECK(error_callback_);
+ DCHECK(result_callback_);
+
// |shell_handler_| owns the callbacks and is guaranteed to be destroyed
// before |this|, therefore making base::Unretained() safe to use.
shell_handler_.set_error_callback(base::Bind(
« no previous file with comments | « no previous file | chrome/browser/ui/webui/welcome_win10_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698