Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: chrome/browser/ui/webui/welcome_win10_handler.cc

Issue 2581473002: DCHECK for a valid error callback callback in GetIsPinnedToTaskbarState (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/shell_integration_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/welcome_win10_handler.cc
diff --git a/chrome/browser/ui/webui/welcome_win10_handler.cc b/chrome/browser/ui/webui/welcome_win10_handler.cc
index 8ae1281acb5171df8bad48ced2235142d840c10a..57d8e12124ef19bc66cc1ac1fb2385db1c358cf4 100644
--- a/chrome/browser/ui/webui/welcome_win10_handler.cc
+++ b/chrome/browser/ui/webui/welcome_win10_handler.cc
@@ -64,8 +64,11 @@ WelcomeWin10Handler::~WelcomeWin10Handler() {
->StartCheckIsDefault();
if (pin_instructions_shown) {
+ // On error, call RecordPinnedResult() with |succeeded| == false.
+ base::Closure error_callback =
+ base::Bind(&RecordPinnedResult, histogram_suffix, false, false);
shell_integration::win::GetIsPinnedToTaskbarState(
- base::Closure(), base::Bind(&RecordPinnedResult, histogram_suffix));
+ error_callback, base::Bind(&RecordPinnedResult, histogram_suffix));
}
}
« no previous file with comments | « chrome/browser/shell_integration_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698