Blacklist method names without considering static-vs-instance.

Stop blacklisting the |trace| method.

This CL helps to consistently blacklist across DeclRewriterBase and
UnresolvedRewriterBase (and therefore to avoid/fix
https://crbug.com/584538) by stopping to blacklist "trace" and
"traceImpl" method names.

We will put together a separate changelist that tweaks the Oilpan's
clang plugin so it will be aware of the new name (|Trace|).  This
change can be probably rolled into https://crrev.com/2329463004.

This CL also tweaks a few other remotely related things:

- Unresolved nodes should never resolve to a function, therefore
  we shouldn't be blacklisting "swap" for unresolved nodes
  (and we can rename the function to IsBlacklistedMethodName).

- IsBlacklistedMethodName stops blacklisting "disable".
  - This enables reusing IsBlacklistedMethodName from IsBlacklistedMethod.
  - Blacklisting "disable" for unresolved nodes was always a heuristic
    (i.e. we cannot tell whether the unresolved method overrides
    blink::InspectorAgent::disable).  Flipping this heuristic around
    seems okay.

BUG=584538
Committed: https://crrev.com/8c6f346940624b5e9b91b95ceeb75960861ad517
Cr-Commit-Position: refs/heads/master@{#439582}

[Łukasz Anforowicz, 2016-12-16 00:32:36]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2016-12-16 00:32:37]

Daniel, can you PTAL?

I think I prefer to 1) skip renaming of some methods (i.e. static "end" and
"trace" methods) with a simple, easy to understand approach rather than 2) try
to rename more methods without having high confidence that this will work (I'd
rather avoid extra heuristics around unresolved expressions).

WDYT?

PS. Some more information about the context is in the comments I've added today
to https://crbug.com/584538

[Łukasz Anforowicz, 2016-12-16 01:12:34]

Description was changed from

==========
Blacklist method names without considering static-vs-instance.

This helps to consistently blacklist across DeclRewriterBase and
UnresolvedRewriterBase.

BUG=584538
==========

to

==========
Stop blacklisting the |trace| method.

This CL helps to consistently blacklist across DeclRewriterBase and
UnresolvedRewriterBase (and therefore to avoid/fix
https://crbug.com/584538) by stopping to blacklist "trace" and
"traceImpl" method names.

We will put together a separate changelist that tweaks the Oilpan's
clang plugin so it will be aware of the new name (|Trace|).  This
change can be probably rolled into https://crrev.com/2329463004.

This CL also tweaks a few other remotely related things:

- Unresolved nodes should never resolve to a function, therefore
  we shouldn't be blacklisting "swap" for unresolved nodes
  (and we can rename the function to IsBlacklistedMethodName).

- IsBlacklistedMethodName stops blacklisting "disable".
  - This enables reusing IsBlacklistedMethodName from IsBlacklistedMethod.
  - Blacklisting "disable" for unresolved nodes was always a heuristic
    (i.e. we cannot tell whether the unresolved method overrides
    blink::InspectorAgent::disable).  Flipping this heuristic around
    seems okay.

BUG=584538
==========

[Łukasz Anforowicz, 2016-12-16 01:14:33]

As we discussed - change of plans.  The plan is to stop blacklisting "trace"
(and account for "trace" -> "Trace" rename in a separate patch for the Oilpan's
clang tool).

Daniel - can you PTAL?  We want to stop blacklisting *both* "trace" and
"traceImpl", right?

[dcheng, 2016-12-16 01:19:26]

LGTM

(but as discussed, let's do an experimental run to see how things go)

[Łukasz Anforowicz, 2016-12-16 20:51:02]

On 2016/12/16 01:19:26, dcheng wrote:
> LGTM
> 
> (but as discussed, let's do an experimental run to see how things go)

nasko@ confirmed that platform:platform and wtf:wtf targets still build after
this patch.  Thanks!

Given above, I'll push this CL out to CQ.

[Łukasz Anforowicz, 2016-12-16 20:51:07]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-12-16 20:52:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 21:00:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 21:00:26]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Łukasz Anforowicz, 2016-12-19 21:43:55]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-12-19 21:44:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 21:58:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482183835491820,
"parent_rev": "b9fd0289fa9f8d760ed091481d5e325798e6fc0b", "commit_rev":
"f9097f9e3d45b55dedb0ccfc5c8f03ffa894937f"}

[commit-bot: I haz the power, 2016-12-19 21:58:53]

Description was changed from

==========
Stop blacklisting the |trace| method.

This CL helps to consistently blacklist across DeclRewriterBase and
UnresolvedRewriterBase (and therefore to avoid/fix
https://crbug.com/584538) by stopping to blacklist "trace" and
"traceImpl" method names.

We will put together a separate changelist that tweaks the Oilpan's
clang plugin so it will be aware of the new name (|Trace|).  This
change can be probably rolled into https://crrev.com/2329463004.

This CL also tweaks a few other remotely related things:

- Unresolved nodes should never resolve to a function, therefore
  we shouldn't be blacklisting "swap" for unresolved nodes
  (and we can rename the function to IsBlacklistedMethodName).

- IsBlacklistedMethodName stops blacklisting "disable".
  - This enables reusing IsBlacklistedMethodName from IsBlacklistedMethod.
  - Blacklisting "disable" for unresolved nodes was always a heuristic
    (i.e. we cannot tell whether the unresolved method overrides
    blink::InspectorAgent::disable).  Flipping this heuristic around
    seems okay.

BUG=584538
==========

to

==========
Stop blacklisting the |trace| method.

This CL helps to consistently blacklist across DeclRewriterBase and
UnresolvedRewriterBase (and therefore to avoid/fix
https://crbug.com/584538) by stopping to blacklist "trace" and
"traceImpl" method names.

We will put together a separate changelist that tweaks the Oilpan's
clang plugin so it will be aware of the new name (|Trace|).  This
change can be probably rolled into https://crrev.com/2329463004.

This CL also tweaks a few other remotely related things:

- Unresolved nodes should never resolve to a function, therefore
  we shouldn't be blacklisting "swap" for unresolved nodes
  (and we can rename the function to IsBlacklistedMethodName).

- IsBlacklistedMethodName stops blacklisting "disable".
  - This enables reusing IsBlacklistedMethodName from IsBlacklistedMethod.
  - Blacklisting "disable" for unresolved nodes was always a heuristic
    (i.e. we cannot tell whether the unresolved method overrides
    blink::InspectorAgent::disable).  Flipping this heuristic around
    seems okay.

BUG=584538

Review-Url: https://codereview.chromium.org/2580773003
==========

[commit-bot: I haz the power, 2016-12-19 21:58:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-19 22:03:34]

Description was changed from

==========
Stop blacklisting the |trace| method.

This CL helps to consistently blacklist across DeclRewriterBase and
UnresolvedRewriterBase (and therefore to avoid/fix
https://crbug.com/584538) by stopping to blacklist "trace" and
"traceImpl" method names.

We will put together a separate changelist that tweaks the Oilpan's
clang plugin so it will be aware of the new name (|Trace|).  This
change can be probably rolled into https://crrev.com/2329463004.

This CL also tweaks a few other remotely related things:

- Unresolved nodes should never resolve to a function, therefore
  we shouldn't be blacklisting "swap" for unresolved nodes
  (and we can rename the function to IsBlacklistedMethodName).

- IsBlacklistedMethodName stops blacklisting "disable".
  - This enables reusing IsBlacklistedMethodName from IsBlacklistedMethod.
  - Blacklisting "disable" for unresolved nodes was always a heuristic
    (i.e. we cannot tell whether the unresolved method overrides
    blink::InspectorAgent::disable).  Flipping this heuristic around
    seems okay.

BUG=584538

Review-Url: https://codereview.chromium.org/2580773003
==========

to

==========
Stop blacklisting the |trace| method.

This CL helps to consistently blacklist across DeclRewriterBase and
UnresolvedRewriterBase (and therefore to avoid/fix
https://crbug.com/584538) by stopping to blacklist "trace" and
"traceImpl" method names.

We will put together a separate changelist that tweaks the Oilpan's
clang plugin so it will be aware of the new name (|Trace|).  This
change can be probably rolled into https://crrev.com/2329463004.

This CL also tweaks a few other remotely related things:

- Unresolved nodes should never resolve to a function, therefore
  we shouldn't be blacklisting "swap" for unresolved nodes
  (and we can rename the function to IsBlacklistedMethodName).

- IsBlacklistedMethodName stops blacklisting "disable".
  - This enables reusing IsBlacklistedMethodName from IsBlacklistedMethod.
  - Blacklisting "disable" for unresolved nodes was always a heuristic
    (i.e. we cannot tell whether the unresolved method overrides
    blink::InspectorAgent::disable).  Flipping this heuristic around
    seems okay.

BUG=584538

Committed: https://crrev.com/8c6f346940624b5e9b91b95ceeb75960861ad517
Cr-Commit-Position: refs/heads/master@{#439582}
==========

[commit-bot: I haz the power, 2016-12-19 22:03:35]

Patchset 2 (id:??) landed as
https://crrev.com/8c6f346940624b5e9b91b95ceeb75960861ad517
Cr-Commit-Position: refs/heads/master@{#439582}