Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc

Issue 2580773003: Blacklist method names without considering static-vs-instance. (Closed)
Patch Set: Stop blacklisting the |trace| method instead. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gen/thing.h" 5 #include "gen/thing.h"
6 6
7 namespace v8 { 7 namespace v8 {
8 8
9 class InterfaceOutsideOfBlink { 9 class InterfaceOutsideOfBlink {
10 public: 10 public:
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 explicit operator int() const { 51 explicit operator int() const {
52 return 42; 52 return 42;
53 } 53 }
54 54
55 // These are special functions that we don't rename so that range-based 55 // These are special functions that we don't rename so that range-based
56 // for loops and STL things work. 56 // for loops and STL things work.
57 MyIterator begin() {} 57 MyIterator begin() {}
58 my_iterator end() {} 58 my_iterator end() {}
59 my_iterator rbegin() {} 59 my_iterator rbegin() {}
60 MyIterator rend() {} 60 MyIterator rend() {}
61 // The trace() method is used by Oilpan, we shouldn't rename it. 61 // The trace() method is used by Oilpan, but we plan to tweak the Oilpan's
62 // clang plugin, so that it recognizes the new method name.
62 void trace() {} 63 void trace() {}
63 // These are used by std::unique_lock and std::lock_guard. 64 // These are used by std::unique_lock and std::lock_guard.
64 void lock() {} 65 void lock() {}
65 void unlock() {} 66 void unlock() {}
66 void try_lock() {} 67 void try_lock() {}
67 }; 68 };
68 69
69 class Other { 70 class Other {
70 // Static begin/end/trace don't count, and should be renamed. 71 // Static begin/end/trace don't count, and should be renamed.
71 static MyIterator begin() {} 72 static MyIterator begin() {}
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 static void method(); 259 static void method();
259 }; 260 };
260 261
261 } // namespace internal 262 } // namespace internal
262 263
263 } // namespace blink 264 } // namespace blink
264 265
265 // https://crbug.com/640688 - need to rewrite method name below. 266 // https://crbug.com/640688 - need to rewrite method name below.
266 void blink::ClassDeclaredInsideBlink::methodDefinedOutsideBlink() {} 267 void blink::ClassDeclaredInsideBlink::methodDefinedOutsideBlink() {}
267 void blink::internal::InternalClass::method() {} 268 void blink::internal::InternalClass::method() {}
OLDNEW
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698