Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc

Issue 2580773003: Blacklist method names without considering static-vs-instance. (Closed)
Patch Set: Stop blacklisting the |trace| method instead. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gen/thing.h" 5 #include "gen/thing.h"
6 6
7 namespace v8 { 7 namespace v8 {
8 8
9 class InterfaceOutsideOfBlink { 9 class InterfaceOutsideOfBlink {
10 public: 10 public:
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 47
48 // Conversion functions should not be rewritten. 48 // Conversion functions should not be rewritten.
49 explicit operator int() const { return 42; } 49 explicit operator int() const { return 42; }
50 50
51 // These are special functions that we don't rename so that range-based 51 // These are special functions that we don't rename so that range-based
52 // for loops and STL things work. 52 // for loops and STL things work.
53 MyIterator begin() {} 53 MyIterator begin() {}
54 my_iterator end() {} 54 my_iterator end() {}
55 my_iterator rbegin() {} 55 my_iterator rbegin() {}
56 MyIterator rend() {} 56 MyIterator rend() {}
57 // The trace() method is used by Oilpan, we shouldn't rename it. 57 // The trace() method is used by Oilpan, but we plan to tweak the Oilpan's
58 void trace() {} 58 // clang plugin, so that it recognizes the new method name.
59 void Trace() {}
59 // These are used by std::unique_lock and std::lock_guard. 60 // These are used by std::unique_lock and std::lock_guard.
60 void lock() {} 61 void lock() {}
61 void unlock() {} 62 void unlock() {}
62 void try_lock() {} 63 void try_lock() {}
63 }; 64 };
64 65
65 class Other { 66 class Other {
66 // Static begin/end/trace don't count, and should be renamed. 67 // Static begin/end/trace don't count, and should be renamed.
67 static MyIterator Begin() {} 68 static MyIterator Begin() {}
68 static my_iterator End() {} 69 static my_iterator End() {}
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 static void Method(); 255 static void Method();
255 }; 256 };
256 257
257 } // namespace internal 258 } // namespace internal
258 259
259 } // namespace blink 260 } // namespace blink
260 261
261 // https://crbug.com/640688 - need to rewrite method name below. 262 // https://crbug.com/640688 - need to rewrite method name below.
262 void blink::ClassDeclaredInsideBlink::MethodDefinedOutsideBlink() {} 263 void blink::ClassDeclaredInsideBlink::MethodDefinedOutsideBlink() {}
263 void blink::internal::InternalClass::Method() {} 264 void blink::internal::InternalClass::Method() {}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698